short http get method #1268
Merged
short http get method #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hi oblomov, alot od f this break with this |
Member
Author
|
Mhh I thought i just deleted the code which was commented anyway or did I miss something? |
Contributor
|
not sure about all of it but im pretty sure lines 381-385 are the part we handle sending object to t_arg |
Contributor
|
last i changed there was in #1116 not sure who else commented it out.. was away from this project for a bit.. |
Contributor
|
oh no my bad, i looked at the wrong thing!! |
Member
Author
|
yes i think i only deleted commented lines, will merge it now, but if something goes wrong, just let me know and we can undo changes. thank you for having an eye on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.