Introduce a way to override how auth tokens are created #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleffert
force-pushed
the
aleffert/swap-tokens
branch
2 times, most recently
from
e2b56e5 to
506469a
Compare
This creates a new setting PASSWORDLESS_AUTH_TOKEN_CREATOR. This is a string representing the function used to construct an authentication token after receiving a valid passwordless token.
aleffert
force-pushed
the
aleffert/swap-tokens
branch
from
506469a to
3750aee
Compare
|
Hi, I totally lost track of this for various reasons. But just went to go take a look at it. I rebased against master, figured out how to run the tests, and fixed the tests that I broke and added one for this change. It sounds like there's some interest in landing this beyond me so would be great to get it in |
|
Looking at it now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new setting PASSWORDLESS_AUTH_TOKEN_CREATOR. This is a
string representing the function used to construct an authentication
token after receiving a valid passwordless token.
Notes: It was not obvious to me how to run the tests, so I did not write tests. Happy to do so with some instructions.