Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 Maintance Updates #14

Merged
merged 19 commits into from May 19, 2018
Merged

2018 Maintance Updates #14

merged 19 commits into from May 19, 2018

Conversation

djstein
Copy link
Contributor

@djstein djstein commented May 16, 2018

  • update urls to paths for Django 2
  • define that only Python 3 is available (depreciate Python 2, if Django foundation is getting rid of it, it's time)
  • add Pipfile and Piplock for Pipenv (https://github.com/pypa/pipenv)
  • update setup.py and associated files based on https://github.com/kennethreitz/setup.py
  • remove parser and throttle class variables such that the user defined REST_FRAMEWORK settings are those used instead. is allows the browse-sable API to be used as well!
  • update gitignore with standard Python values
  • update README to use markdown over rst as new PyPi now supports it!
  • remove string formating using % as it is slower than using .format()
  • use absolute paths over relative paths
  • general style updates

@djstein
Copy link
Contributor Author

djstein commented May 16, 2018

@jakeprem anything you want to weight in on?

@djstein
Copy link
Contributor Author

djstein commented May 16, 2018

I am attempting to update the .travis.yml and tox.ini files based on what is described here but need a bit of help!

setup.py Outdated
@@ -26,7 +26,7 @@

# What packages are required for this module to be executed?
REQUIRED = [
# 'requests', 'maya', 'records',
'Django', 'djangorestframework'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put this here instead of the pipfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed since we are still using setup.py to package, we need to require these. As they are the true base of the project. However, if it can be package and installed without these by all means I think we should remove it!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, nevermind– this makes sense.

@djstein
Copy link
Contributor Author

djstein commented May 19, 2018

@aaronn how do you feel about the switch to Django 2 aka Python 3 only?

@aaronn
Copy link
Owner

aaronn commented May 19, 2018

@djstein I'm cool with switching to Python 3 and Django 2

Dylan Stein and others added 2 commits May 19, 2018 15:29
@djstein
Copy link
Contributor Author

djstein commented May 19, 2018

@aaronn got builds to pass on Python 3.5 and above, thoughts on removing 3.3, 3.4 from build?

@aaronn
Copy link
Owner

aaronn commented May 19, 2018

@djstein oops, sorry– just changed some stuff. yeah I don't mind going 3.6+ even

@djstein
Copy link
Contributor Author

djstein commented May 19, 2018

haha with my previous commit it worked without tox-travis should we use tox-travis or just standard tox?
Edit: I am not familiar with tox-travis

@djstein djstein closed this May 19, 2018
@djstein djstein reopened this May 19, 2018
@aaronn
Copy link
Owner

aaronn commented May 19, 2018

@djstein feel free to roll 9c08d8b back and take out tox-travis. thought I figured out what was causing the travis failures. I'm not really familiar with tox or travis.

@@ -0,0 +1,3 @@
VERSION = (1, 1, 5)
Copy link
Owner

@aaronn aaronn May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change this to (1, 2, 0) and update it to 1.2.0 in __init__.py so I can upload to Pypi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure, I didn't want to change it since I can't upload!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djstein yeah, I can take care of this later myself once we get tests to pass too

@djstein
Copy link
Contributor Author

djstein commented May 19, 2018

so for the tox file:
[tox]
envlist = flake8-py3, py36, pypy
do we also need to remove those and let the environment be decided by the travis python version

@aaronn
Copy link
Owner

aaronn commented May 19, 2018

@djstein not sure, you had 3.5+ working earlier right? let's just use whatever you had working there

@aaronn aaronn merged commit 053d25a into aaronn:master May 19, 2018
@aaronn
Copy link
Owner

aaronn commented May 19, 2018

@djstein seems like it's passing fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants