-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2018 Maintance Updates #14
Conversation
djstein
commented
May 16, 2018
- update urls to paths for Django 2
- define that only Python 3 is available (depreciate Python 2, if Django foundation is getting rid of it, it's time)
- add Pipfile and Piplock for Pipenv (https://github.com/pypa/pipenv)
- update setup.py and associated files based on https://github.com/kennethreitz/setup.py
- remove parser and throttle class variables such that the user defined REST_FRAMEWORK settings are those used instead. is allows the browse-sable API to be used as well!
- update gitignore with standard Python values
- update README to use markdown over rst as new PyPi now supports it!
- remove string formating using % as it is slower than using .format()
- use absolute paths over relative paths
- general style updates
…t over %; rename log to logger
@jakeprem anything you want to weight in on? |
I am attempting to update the |
setup.py
Outdated
@@ -26,7 +26,7 @@ | |||
|
|||
# What packages are required for this module to be executed? | |||
REQUIRED = [ | |||
# 'requests', 'maya', 'records', | |||
'Django', 'djangorestframework' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put this here instead of the pipfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed since we are still using setup.py
to package, we need to require these. As they are the true base of the project. However, if it can be package and installed without these by all means I think we should remove it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool, nevermind– this makes sense.
@aaronn how do you feel about the switch to Django 2 aka Python 3 only? |
@djstein I'm cool with switching to Python 3 and Django 2 |
Need a TOX_ENV env var
@aaronn got builds to pass on Python 3.5 and above, thoughts on removing 3.3, 3.4 from build? |
@djstein oops, sorry– just changed some stuff. yeah I don't mind going 3.6+ even |
haha with my previous commit it worked without |
This reverts commit 9c08d8b.
@@ -0,0 +1,3 @@ | |||
VERSION = (1, 1, 5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change this to (1, 2, 0) and update it to 1.2.0 in __init__.py
so I can upload to Pypi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure, I didn't want to change it since I can't upload!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djstein yeah, I can take care of this later myself once we get tests to pass too
so for the tox file: |
@djstein not sure, you had 3.5+ working earlier right? let's just use whatever you had working there |
@djstein seems like it's passing fine? |