feat: better parallelism and miscellaneous optimizations #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
reviewed
Aug 18, 2025
Comment on lines
31
to
28
| OneHot(OneHotPolynomial<F>), | ||
| OneHot(Arc<OneHotPolynomial<F>>), |
There was a problem hiding this comment.
can we avoid putting the Arc here (i.e. only introduce Arc when doing linear_combination?)
moodlezoup
reviewed
Aug 18, 2025
jolt-core/src/poly/opening_proof.rs
Outdated
| .polynomials | ||
| .par_iter() | ||
| .map(|label| polynomials_map.get(label).unwrap()) | ||
| .map(|label| Arc::new(polynomials_map.get(label).unwrap().clone())) |
There was a problem hiding this comment.
If we separate MultilinearPolynomial::linear_combination into two different functions:
RLCPolynomial::from_linear_combination(polynomials: Vec<Arc<MultilinearPolynomial<F>>>, coefficients: &[F]) and DensePolynomial::from_linear_combination(polynomials: &[&MultilinearPolynomial<F>], coefficients: &[F]), then we'd be able to avoid the clone here
markosg04
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear_combinationfrom 40s at 2^28 to ~1s