Clarify descriptions of control flow operators #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
Nov 21, 2024
| | `delegate` | `0x18` | relative_depth : `varuint32` | begins the delegate block of the try block | | ||
| | `throw` | `0x08` | index : `varint32` | Creates an exception defined by the tag and then throws it | | ||
| | `rethrow` | `0x09` | relative_depth : `varuint32` | Pops the `exnref` on top of the stack and throws it | | ||
| | `delegate` | `0x18` | relative_depth : `varuint32` | ends the current try block and delegates any exceptions to the block at `relative_depth` | |
There was a problem hiding this comment.
Thanks! It looks the old text is a copy-pasta of catch description...
| | `rethrow` | `0x09` | relative_depth : `varuint32` | Pops the `exnref` on top of the stack and throws it | | ||
| | `delegate` | `0x18` | relative_depth : `varuint32` | ends the current try block and delegates any exceptions to the block at `relative_depth` | | ||
| | `throw` | `0x08` | index : `varint32` | creates an exception defined by the tag and then throws it | | ||
| | `rethrow` | `0x09` | relative_depth : `varuint32` | throws the exception caught by the catch block at `relative_depth` | |
There was a problem hiding this comment.
Hmm it looks like the remnants of the pre-legacy proposal that preceded the legacy proposal. Thanks for the catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon the
exnrefmentioning in therethrow.I also slightly adapted the description for the delegate as it sounds like the delegate was opening a new block while it finishes / ends the current try block.