Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.x #1

Open
wants to merge 176 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
176 commits
Select commit Hold shift + click to select a range
6424232
Reflect websocket proxy support on README (#1013) (#1483)
frontsideair Feb 4, 2017
65e6340
Edit User Guide: Add ESLint config for VS Code users (#1482)
Feb 4, 2017
adab23f
e2e: Reduce complexity of e2e and improve Jest coverage (#1484)
Timer Feb 4, 2017
9e0e18f
UX: Explain why build is failing (#1352)
jayphelps Jan 5, 2017
0ac0d11
Update comments for webpack loaders
ro-savage Feb 8, 2017
c811a31
Change "OS X" references to "macOS" (#1511)
RodrigoHahn Feb 9, 2017
de6e059
corrected minor typo (#1514)
Feb 9, 2017
160d8d1
clarifying the use of custom environment variables (#1513)
calweb Feb 9, 2017
b999405
Add missing '\n' to the end of `package.json` file (#1510)
pd4d10 Feb 9, 2017
1d9159d
Make all react app vars accessible in index.html (#1440)
jihchi Feb 10, 2017
613b584
Add `PUBLIC_URL` env variable for advanced use (#937) (#1504)
Timer Feb 10, 2017
8e127aa
Support relative asset paths for special case (#1489)
tibdex Feb 10, 2017
7a02f9a
readme: Add Advanced Configuration (#1515)
Timer Feb 10, 2017
e19b0f6
Make build exit with error code when interrupted (#1496)
brandones Feb 11, 2017
ac39a46
Bump lerna
gaearon Feb 11, 2017
b9d679a
Add test cases for PUBLIC_URL and relative path (#1519)
Timer Feb 11, 2017
5211141
Add an annoying nit
gaearon Feb 11, 2017
354fce0
Upgrade babel dependencies
Timer Feb 11, 2017
7556997
Don't run CI on Node 0.10 (#1521)
gaearon Feb 11, 2017
b0b0e6d
fix: add yarn gitignores (#1507)
AndersDJohnson Feb 11, 2017
15e0b98
Upgrade dependencies (#1522)
Timer Feb 11, 2017
84be4dd
Add CHANGELOG
Timer Feb 11, 2017
67e6cf5
Publish
Timer Feb 11, 2017
dc4e8bb
Make index.html interpolation instructions less clashing with env syntax
gaearon Feb 11, 2017
9f12763
Add additional info about env variables
gaearon Feb 11, 2017
c8644e2
Massage 0.9.0 changelog
gaearon Feb 11, 2017
0e74539
Add release cutters to changelog
gaearon Feb 11, 2017
7ea799d
Tweak indentation
gaearon Feb 11, 2017
0bcb284
Markdown whitespace fixes
gaearon Feb 11, 2017
3e226b2
Some changelog formatting
gaearon Feb 11, 2017
12e8cea
Suggest jest-enzyme for simplifying test matchers (#994)
blainekasten Feb 11, 2017
645ba66
Add SASS support documentation #1007 (#1008)
tsironis Feb 12, 2017
27c99b5
Link to new Sass doc
gaearon Feb 12, 2017
1b3403b
Clarify Less/Sass support
gaearon Feb 12, 2017
6a0edc4
Fix `test -e` with wildcard arguments. (#1503)
marcusrbrown Feb 12, 2017
7f35c79
Correctly Command in README.md (#1275)
lifez Feb 12, 2017
60902dc
reactjs/redux#2004 List features beyond ES6 supported by create-react…
jonathanconway Feb 12, 2017
c861f74
Add a link to supported features
gaearon Feb 12, 2017
d53228d
[documentation] how to disable autoprefix feature (#1320)
Feb 12, 2017
ed47cc3
Added link to Azure deployment tutorial (#1338)
tpetrina Feb 12, 2017
572d07b
Add useful link to react-scripts (#1495)
pd4d10 Feb 12, 2017
963383a
Update language support wording to ES2017
Timer Feb 12, 2017
1aefc2c
Tweak syntax doc (#1539)
gaearon Feb 12, 2017
b279e3f
Make node version check more robust in e2e.sh (#1295)
pugnascotia Feb 13, 2017
677896a
update CSS preprocessor instructions (#1543)
Feb 13, 2017
01f66db
Revert "Don't run CI on Node 0.10" (#1547)
Timer Feb 13, 2017
cb95889
Use Yarn latest in e2e (#1534)
gaearon Feb 15, 2017
8c375ac
modified documentation for setting up jest-enzyme (#1562)
kiranps Feb 15, 2017
41f9d20
Use https in link to Ignoring files at Github (#1561)
Feb 15, 2017
6ae2d06
add --recursive to sass watch script (#1564)
Feb 15, 2017
8780078
Mention Windows support explicitly
gaearon Feb 15, 2017
d6781af
Reorder
gaearon Feb 16, 2017
c7d6a5d
Update README.md (#1573)
mkermani144 Feb 16, 2017
af345f0
MacOS => macOS
gaearon Feb 16, 2017
20b85ba
Switch from Neo to Neutrino (#1576)
eliperelman Feb 17, 2017
71be55b
fixes #1584 PORT env variable not always an integer (#1585)
matoilic Feb 18, 2017
0a41334
babel-preset: remove babel-plugin-transform-es2015-parameters (#1598)
christophehurpeau Feb 21, 2017
bf0c02e
Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable …
AJamesPhillips Feb 22, 2017
321f8b4
Allow --scripts-version to be a git url (#1570)
tomconroy Feb 23, 2017
7c4c167
Install react, react-dom, and react-scripts at the same time (#1253)
n3tr Feb 23, 2017
d4f3985
add a comment about NODE_ENV value set to 'production' during build s…
mderazon Feb 24, 2017
fb94589
Update flow configuration documentation (#1518)
SBrown52 Feb 24, 2017
5ee655b
Add note about when to import bootstrap CSS. (#1618)
joewoodhouse Feb 24, 2017
16a5e55
Document Sass imports
gaearon Feb 24, 2017
ce90532
Fix workflow if react-scripts package is linked via npm-link (#1356)
tuchk4 Feb 24, 2017
9e51852
Document debugging in the browser. (#1540)
bondz Feb 24, 2017
def004a
Link to "Debugging in the Editor"
gaearon Feb 24, 2017
0dcf973
Adding link to “Customizing” create-react-app (#1121)
Feb 24, 2017
8cf9155
Update index.js (#1603)
driquelme Feb 24, 2017
2177030
Remove .bin files defined at react-scripts/package.json after eject …
tuchk4 Feb 24, 2017
627e67d
Bump `recursive-readdir`. (#1560)
wtgtybhertgeghgtwtg Feb 24, 2017
93f7aef
Added a how-to on react-snapshot (#1577)
superhighfives Feb 24, 2017
3b5434c
NPM version check for tip (#1193)
rangle-mobinni Feb 24, 2017
bf11b14
Enable eslint caching in development (#1578)
viankakrisna Feb 24, 2017
fd248ec
Use real build path name in build output (#1478)
chyipin Feb 24, 2017
78882d5
adding a note on how to resolve "Could not find a required file." dep…
Feb 24, 2017
913679b
Use posix paths for Jest config during eject (#1635)
Timer Feb 24, 2017
1fe3e14
Setting a dynamic port value for the pushstate-server URL text (#1628)
mattccrampton Feb 24, 2017
11851ee
Fix up broken line
gaearon Feb 24, 2017
36d86b9
Gracefully handle initial installation error (#1512)
chitchu Feb 25, 2017
f160a81
Add changelog for 0.9.1
Timer Feb 26, 2017
9e2624f
Publish
Timer Feb 26, 2017
0ad2c72
Update changelog
Timer Feb 26, 2017
eb34d80
Fix npm test on Windows (#1647)
gaearon Feb 26, 2017
28d6f32
Add 0.9.2 changelog
gaearon Feb 26, 2017
0c2603f
0.9.2
gaearon Feb 26, 2017
6370c00
Add a note about known issue
gaearon Feb 26, 2017
8fa04c2
Merge changelogs
gaearon Feb 26, 2017
f0b1408
Format differently
gaearon Feb 26, 2017
5a91a01
Set Chrome userDataDir to be under .vscode folder (#1657)
ryansully Feb 27, 2017
a06c95b
Fix e2e when used with cold cache (#1667)
Timer Feb 27, 2017
a1bc3a3
Fix e2e-simple (cont.)
Timer Feb 27, 2017
c5d8cfd
Add appveyor.yml (#1648)
Timer Feb 27, 2017
649c346
fix react dependency versions during initial install (#1669)
johann-sonntagbauer Feb 28, 2017
39d0952
Remove Windows 0.10 simple test
Timer Feb 28, 2017
a2c5be9
add project name validation (#1662)
johann-sonntagbauer Feb 28, 2017
0b46850
fix project cleanup on windows (#1675)
johann-sonntagbauer Feb 28, 2017
5bce8c5
Revert "Enable eslint caching in development" (#1665)
gaearon Feb 28, 2017
8591902
add X-FORWARDED headers for proxy requests (#1677)
johann-sonntagbauer Feb 28, 2017
a319002
Use offline cached version with yarn when it's possible (#1423)
voxsim Feb 28, 2017
4446759
Add 0.9.3 changelog (#1683)
gaearon Feb 28, 2017
0d752f5
Add "migrating" section for 0.9.3
gaearon Feb 28, 2017
aaf1e81
Publish
gaearon Feb 28, 2017
9e8910f
False expression should not be in dependencies
Timer Feb 28, 2017
36f3c55
Publish
Timer Feb 28, 2017
e1dac99
appveyor: Build all branches
Timer Mar 1, 2017
7a6a3c8
Suggest CRA 1.2.1 in changelog
gaearon Mar 1, 2017
290e619
Fixed missing flag in first preprocess command (#1687)
mklemme Mar 1, 2017
58137b7
Re-enable e2e-install directory test
Timer Mar 1, 2017
008d9a1
Suggest to use .env for enabling polling mode (#1698)
gaearon Mar 2, 2017
2580b52
Diagnostic code (#1695)
tgig Mar 2, 2017
5fbb13a
Fix Jest tests for Cygwin
Timer Mar 3, 2017
734fc98
Improve reliability of port hint. (#1696)
chrisdrackett Mar 3, 2017
b9b6135
pin and bump lerna (#1688)
viankakrisna Mar 4, 2017
5ba8709
Lerna 2.0.0-beta.38 expects packages entry
Timer Mar 4, 2017
297ce6a
Add docs for apache's client side routing setting (#1717)
viankakrisna Mar 5, 2017
7d82964
Update now.sh deployment instructions. (#1710)
replaid Mar 5, 2017
474af9e
Add support for ignoreRestSiblings in no-unused-vars (#1705)
chrisdrackett Mar 5, 2017
99aa02d
add double quotes to escape spaces in paths in e2e (#1707)
viankakrisna Mar 5, 2017
66d59bb
Create appveyor.cleanup-cache.txt
gaearon Mar 5, 2017
c017e2c
Link Appveyor caches to appveyor.cleanup-cache.txt
gaearon Mar 5, 2017
be53fa5
Trigger AppVeyor cache cleanup
gaearon Mar 5, 2017
7daff97
Fix hot reloading for WebpackDevServer after eject (#1721)
gaearon Mar 5, 2017
860f1c7
Fix openBrowser() when BROWSER=open on macOS (#1690)
bpierre Mar 5, 2017
ebf5bd5
Create empty package.json in e2e test (#1401) (#1402)
matoilic Mar 5, 2017
6f18606
Skip AppVeyor CI builds for Markdown changes (#1723)
gaearon Mar 5, 2017
830fe20
Don't use ES6 in a file that should run on Node 4 (#1724)
gaearon Mar 5, 2017
b0b9696
Bump jsx-a11y version (#1542)
bondz Mar 5, 2017
6a9e4dc
Bump ESLint config to 0.6.0 manually
gaearon Mar 5, 2017
b34a679
Fix Node 4 e2e tests (#1730)
Timer Mar 5, 2017
b210d7a
Lint internal scripts with eslint:recommended (#1729)
gaearon Mar 5, 2017
1a331e1
Fix ejecting from a scoped fork (#1727)
gaearon Mar 5, 2017
96fe3fc
Properly extract package name for installing tgz of scoped packages (…
Timer Mar 5, 2017
556f394
extract generic build functions to react-dev-utils (#1726)
viankakrisna Mar 6, 2017
57d8596
Bust AppVeoyr cache
gaearon Mar 6, 2017
623c28b
Relax ESLint config peerDependency (#1740)
gaearon Mar 6, 2017
0d0df6a
Fix internal linting setup and add missing headers (#1741)
gaearon Mar 6, 2017
fc5d405
Fix lint
gaearon Mar 6, 2017
8cc5dcc
Fix eject for linked react-scripts (#1736)
tuchk4 Mar 6, 2017
63488c6
Add changelog for 0.9.4
Timer Mar 6, 2017
422847b
Publish
Timer Mar 6, 2017
aa434d5
Adjust changelog wording
Timer Mar 6, 2017
0811775
Switch to preset-env (#1742)
Timer Mar 7, 2017
d24f98a
Display yarn instead of yarnpkg when creating a new app (#1747)
lpalmes Mar 7, 2017
06086f9
Add yarn steps for adding flow (#1756)
zertosh Mar 7, 2017
f4a4e8f
Suggest `serve` for running in production (#1760)
leo Mar 8, 2017
6ca7a7b
Remove 'guard-for-in' lint rule (#1773)
sophiebits Mar 9, 2017
67d0403
Run CI on Node 7; Bump detect-port: 1.0.1 -> 1.1.0 (#1776) (#1783)
ryanwalters Mar 9, 2017
5282dc3
Add 0.9.5 changelog (#1784)
gaearon Mar 9, 2017
9b23762
Publish
gaearon Mar 9, 2017
356603f
docs(babel-preset): Update comment info about babel-preset-env. (#1787)
evenchange4 Mar 10, 2017
1b47336
Feature/readme-nomoretools (#1799)
moniuch Mar 11, 2017
bc9aca8
Suggest "yarn build" rather than "yarn run build" (#1800)
geoffdavis92 Mar 12, 2017
b103ed7
Tweak the wording
gaearon Mar 13, 2017
b9e549e
Link to CRNA
gaearon Mar 14, 2017
e3db147
Allow creation of apps in empty mercurial repos (#1811)
GreenGremlin Mar 15, 2017
022822b
Make Surge guide more focused
gaearon Mar 18, 2017
32cd4fe
User Guide: Removed blockquote from code section, due to markdown con…
stochris Mar 21, 2017
1e40708
Fix AppVeyor CI (#1876)
darrenscerri Mar 22, 2017
40f558b
Fix responsive behavior in iOS 9+ (#1821)
GreenGremlin Mar 22, 2017
825b77c
Check internet connectivity with lookup instead of resolve (#1863)
kdleijer Mar 22, 2017
a5479de
Update `detect-port` (#1861)
Andreyco Mar 22, 2017
d9fc932
Fix importing linked packages (#1884)
Timer Mar 23, 2017
ebebe80
Fix AppVeyor CI (#1868)
darrenscerri Mar 24, 2017
df7c067
Suggest Yarn in HTML template (#1911)
tmos Apr 5, 2017
40d1b17
Note that only jest-enzyme@2.x is compatible
gaearon Apr 9, 2017
8bd395a
Add sku to the list of alternatives (#1962)
markdalgleish Apr 10, 2017
3d8c820
Update information in User Guide for Enzyme dependency (#1982)
josephrace Apr 14, 2017
10dfd89
Ensure proxy url starts with `http://` or `https://` (#1890)
bunshar Apr 15, 2017
4b92fd3
Update ansi-html to fix #1881
Timer Apr 15, 2017
51f34f1
Add linked modules test (0.9.x) (#1912)
Timer Apr 15, 2017
19e0386
Add note about installing watchman (#1950)
just-boris Apr 15, 2017
604519a
Start the dev server at the specified host
GAumala Dec 21, 2016
47659a6
Add folder structure docs for new contributors (#1991)
anilreddykatta Apr 19, 2017
a0c37ca
Relax label rules (#1989)
Timer Apr 19, 2017
144f03b
Update doc server example to work from any directory (#1988)
isramos Apr 19, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add project name validation (facebook#1662)
* add project name validation

* Tweak console output
  • Loading branch information
johann-sonntagbauer authored and gaearon committed Feb 28, 2017
commit a2c5be9898d7ace738f286f71433db63e34a12ff
18 changes: 17 additions & 1 deletion packages/create-react-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
'use strict';

var chalk = require('chalk');
var validateProjectName = require("validate-npm-package-name");

var currentNodeVersion = process.versions.node;
if (currentNodeVersion.split('.')[0] < 4) {
Expand Down Expand Up @@ -97,6 +98,14 @@ if (typeof projectName === 'undefined') {
process.exit(1);
}

function printValidationResults(results) {
if (typeof results !== 'undefined') {
results.forEach(function (error) {
console.error(chalk.red(' * ' + error));
});
}
}

var hiddenProgram = new commander.Command()
.option('--internal-testing-template <path-to-template>', '(internal usage only, DO NOT RELY ON THIS) ' +
'use a non-standard application template')
Expand Down Expand Up @@ -304,11 +313,18 @@ function checkNodeVersion(packageName) {
}

function checkAppName(appName) {
var validationResult = validateProjectName(appName);
if (!validationResult.validForNewPackages) {
console.error('Could not create a project called ' + chalk.red('"' + appName + '"') + ' because of npm naming restrictions:');
printValidationResults(validationResult.errors);
printValidationResults(validationResult.warnings);
process.exit(1);
}

// TODO: there should be a single place that holds the dependencies
var dependencies = ['react', 'react-dom'];
var devDependencies = ['react-scripts'];
var allDependencies = dependencies.concat(devDependencies).sort();

if (allDependencies.indexOf(appName) >= 0) {
console.error(
chalk.red(
Expand Down
3 changes: 2 additions & 1 deletion packages/create-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"commander": "^2.9.0",
"cross-spawn": "^4.0.0",
"fs-extra": "^1.0.0",
"semver": "^5.0.3"
"semver": "^5.0.3",
"validate-npm-package-name": "^3.0.0"
}
}