Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the compatibility of some regular expressions in JavaScript. #15

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

VincentSit
Copy link
Owner

@VincentSit VincentSit commented Jan 10, 2019

Since JavaScript is not compatible with PCRE, some useful features (such as Lookbehind, If-Then-Else Conditionals, etc.) are not supported, regular expressions that use these features cannot be parsed by JavaScript's regular expression engine. This PR optimization the syntax of these regular expressions ensures that JavaScript handles them correctly.

Thanks @fy0 for pointing this out.

@VincentSit VincentSit merged commit 88f72a3 into master Jan 10, 2019
@VincentSit VincentSit deleted the js_compatibility branch January 10, 2019 12:41
@fy0
Copy link

fy0 commented Jan 10, 2019

非常感谢,前后端可以一起用了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants