perf: improved runtime performance, dirty objects #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de.gameobjects into perf/improved-performance
jeffreyrainy
commented
Aug 12, 2022
com.unity.netcode.gameobjects/Tests/Runtime/NetworkVarBufferCopyTest.cs
Outdated
Show resolved
Hide resolved
…e-enabling test, making it use SetDirty() properly
com.unity.netcode.gameobjects/Runtime/NetworkVariable/NetworkVariableBase.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/NetworkVariable/NetworkVariableBase.cs
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/NetworkVariable/Collections/NetworkList.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs
Outdated
Show resolved
Hide resolved
becksebenius-unity
approved these changes
Aug 15, 2022
com.unity.netcode.gameobjects/Tests/Runtime/Metrics/NetworkVariableMetricsTests.cs
Show resolved
Hide resolved
…leWrite' PR review comment
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…#2116) * Performance fix for large number of NetworkObjects * docs: style: changelog and coding convention * fixes tests (but not NetworkList ones) * Fixes NetworkList functionality * disabling incompatible test * test adjustment, following improvement in NetworkVariable sending * Merging two loops to scan over objects one less time (performance). Re-enabling test, making it use SetDirty() properly * improved naming, fixed tests * addressing 'This seems like it should be handled by PostNetworkVariableWrite' PR review comment * refactoring common part to duplicated code paths into a single instance * limiting m_IsDirty visibility, to encourage using SetDirty() Co-authored-by: starchitectus <acarija@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames NetwoirkBehaviourUpdater's
m_Touchedtom_DirtyNetworkObjectsInstead of scanning all spawned objects, for each client, then checking visibility and updating,
we now scan only over the dirty objects and then over all clients for visibility.
Since few objects are dirty, typically, this improves performance.
Changelog