Create key/value map in WebSocket

[rjbergTU]

It would be nice if each WebSocket had a map for key/value pairs. This way you can keep track of different clients in a simple way. I have seen other server classes in other projects using this kind of functionality.

[marci4]

Hello @rjbergTU,

first of all thanks a lot for your input :)

I have the following "problems" with your idea:

• Does everybody need this? (Every websocket server keeping a map containing websocket clients keeping a map)
• What are the best key/value classes? (Probably resulting into <Object,Object> so everybody has to cast their results)
• Are custom implementations not more efficient/intuitive?

Greetings
marci4

[Irahe]

Well,

On my project i use this kind of mapping for authentication and identification proposes.
I have created two separated chasses and two Synchronized lists on the Server class, so i can keep track of this.
I believe this is not the role of the lib, but a specificity of each implementation.

Greetings. :*

PS: If you will use this kind of approach, don't forget to use Iterators for manipulating the lists....

[rjbergTU]

Hello @marci4

Regarding your feedback, I have the following things:

1.a No, not everybody needs this. But I do believe it is very common to be able to distinguish between clients and assign them variables.
1.b I actually was more talking about a map in the WebSocket implementations then one in the server or client. This makes it easier then a map which maps WebSockets to other maps.

2. I think it is no problem if keys have to be Strings. It is also more useful with map implementations that need instances of Comparable, like TreeMap. I would recommend using Objects for values though.

3. Maybe, but it is a bit of a hassle to modify WebsocketImpl, or to assign a map in each server mapping WebSocket to other maps, which need their own keys. In other words I think it is easier to be able to write something like webSocket.get(key) in the server instead of socketMap.get(webSocket).get(key).

Edit: By the way, thanks for adding labels. I had forgotten about them.

[marci4]

Concept and implementation for future release!

[lifubang]

I think if the maintainer provide a clientid field in org.java_websocket.WebSocketImpl class, the map can be maintained by ourselves. (#554)

But I also think that because the class org.java_websocket.server.WebSocketServer provide a private field Collection connections, if this field changes to Dictionary<String, WebSocket> connections, It'll be more Convenient for us. But it will need more code changes. So I think it's not a good idea.

So I think you can add a clientid field in org.java_websocket.WebSocketImpl class, the problem will be resolved with a lowest cost.