Closed
Description
GitHub event:
-
pull_request:opened
-
pull_request:synchronize
-
pull_request:ready_for_review
-
pull_request:closed
-
pull_request:labeled
-
pull_request:unlabeled
-
pull_request_review:submitted
-
check_run:completed
-
issues:opened
Example pull request/issue:
Steps to reproduce the bug:
- Pull request has been opened, no errors found, and all tests passed => bot adds the
awaiting reviews
label - Then a maintainer approves the pull request and tries to remove the label
awaiting reviews
but the bot adds it back as it still thinks the review is pending.
Proposal:
The solution would be to remove the awaiting reviews
label when a pull request has been approved and not add it back on the pull_request:unlabeled
event.
The above example is a rare case because the bot was not installed when the pull request was opened, thus the bot did not add awaiting reviews
label and so it thought the review was still pending.