feat: Add kosajura algorithm for finding strong connected components #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
approved these changes
Dec 30, 2023
Contributor
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Your space complexity analysis is correct, the transposed graph requires O(V + E) space in this implementation. (Other graph data structures might store both in- and out-edges for each node, hence not needing auxiliary space for the transposition.)
raklaptudirm
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://en.wikipedia.org/wiki/Kosaraju%27s_algorithm
I found a couple of articles online that suggest that the space complexity is O(V), for creating a the visited array and priority stack. I think it should actually be O(V + E), because the transposed graph needs to hold E edges. I think my analysis is correct, but have not found any sources online to confirm it.