feat: add square root #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britneywwc
requested review from
Panquesito7,
appgurueu and
raklaptudirm
as code owners
appgurueu
reviewed
Oct 17, 2023
Contributor
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Tests (for valid values) could use each. You should also use toBeCloseTo since the algorithm just guarantees a solution within a precision and not an exact solution; I'd also recommend additionally testing some irrational roots.
Contributor
Author
|
@appgurueu Thanks for reviewing. I've updated the fixes according to your suggestions. |
appgurueu
previously approved these changes
Oct 18, 2023
Contributor
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Please get rid of the changes to ugly_numbers.ts, though.
appgurueu
approved these changes
Oct 20, 2023
raklaptudirm
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation for square root.