-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
merge double_factorial #9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tianyizheng02
merged 7 commits into
TheAlgorithms:master
from
AVAniketh0905:merge-double-factorial
Oct 3, 2023
Merged
merge double_factorial #9431
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dbf8671
merge double_factorial
AVAniketh0905 360c520
fix ruff error
AVAniketh0905 d435314
merge conflicts
AVAniketh0905 cdd5619
fix merge issues
AVAniketh0905 8f9e16c
Merge branch 'TheAlgorithms:master' into merge-double-factorial
AVAniketh0905 b230795
change test case
AVAniketh0905 189eb25
fix import error
AVAniketh0905 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
def double_factorial_recursive(n: int) -> int: | ||
tianyizheng02 marked this conversation as resolved.
Show resolved
Hide resolved
tianyizheng02 marked this conversation as resolved.
Show resolved
Hide resolved
tianyizheng02 marked this conversation as resolved.
Show resolved
Hide resolved
tianyizheng02 marked this conversation as resolved.
Show resolved
Hide resolved
tianyizheng02 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
""" | ||
Compute double factorial using recursive method. | ||
Recursion can be costly for large numbers. | ||
|
||
To learn about the theory behind this algorithm: | ||
https://en.wikipedia.org/wiki/Double_factorial | ||
|
||
>>> from math import prod | ||
>>> all(double_factorial_recursive(i) == prod(range(i, 0, -2)) for i in range(20)) | ||
True | ||
>>> double_factorial_recursive(0.1) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: double_factorial_recursive() only accepts integral values | ||
>>> double_factorial_recursive(-1) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: double_factorial_recursive() not defined for negative values | ||
""" | ||
if not isinstance(n, int): | ||
raise ValueError("double_factorial_recursive() only accepts integral values") | ||
if n < 0: | ||
raise ValueError("double_factorial_recursive() not defined for negative values") | ||
return 1 if n <= 1 else n * double_factorial_recursive(n - 2) | ||
|
||
|
||
def double_factorial_iterative(num: int) -> int: | ||
""" | ||
Compute double factorial using iterative method. | ||
|
||
To learn about the theory behind this algorithm: | ||
https://en.wikipedia.org/wiki/Double_factorial | ||
|
||
>>> from math import prod | ||
>>> all(double_factorial_iterative(i) == prod(range(i, 0, -2)) for i in range(20)) | ||
True | ||
>>> double_factorial_iterative(0.1) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: double_factorial_iterative() only accepts integral values | ||
>>> double_factorial_iterative(-1) | ||
Traceback (most recent call last): | ||
... | ||
ValueError: double_factorial_iterative() not defined for negative values | ||
""" | ||
if not isinstance(num, int): | ||
raise ValueError("double_factorial_iterative() only accepts integral values") | ||
if num < 0: | ||
raise ValueError("double_factorial_iterative() not defined for negative values") | ||
value = 1 | ||
for i in range(num, 0, -2): | ||
value *= i | ||
return value | ||
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
doctest.testmod() |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.