Skip to content

algorithm: Add juggler sequence #7985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Prev Previous commit
Next Next commit
refactor: Change error type for negative numbers
  • Loading branch information
itsAkshayDubey committed Nov 15, 2022
commit a0a875a711c68b1b5139915da6b8cc7d772418e8
10 changes: 4 additions & 6 deletions maths/juggler_sequence.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def juggler_sequence(number: int) -> list[int]:
>>> juggler_sequence(0)
Traceback (most recent call last):
...
TypeError: Input value of [number=0] must be greater than 0
ValueError: Input value of [number=0] must be a positive integer
>>> juggler_sequence(1)
[1]
>>> juggler_sequence(2)
Expand All @@ -34,14 +34,12 @@ def juggler_sequence(number: int) -> list[int]:
>>> juggler_sequence(-1)
Traceback (most recent call last):
...
TypeError: Input value of [number=-1] must be positive
ValueError: Input value of [number=-1] must be a positive integer
"""
if not isinstance(number, int):
raise TypeError(f"Input value of [number={number}] must be an integer")
if number < 0:
raise TypeError(f"Input value of [number={number}] must be positive")
if number == 0:
raise TypeError(f"Input value of [number={number}] must be greater than 0")
if number < 1:
raise ValueError(f"Input value of [number={number}] must be a positive integer")
sequence = [number]
while number != 1:
if number % 2 == 0:
Expand Down