Create recursive_approach_knapsack.py #7587
Conversation
Added a new naïve recursive approach to solve the knapsack problem.
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| ans2 = values[index] + knapsack(weights,values,n,max_weight-weights[index],index+1) | ||
| return max(ans1,ans2) | ||
|
|
||
| def take_input() : |
There was a problem hiding this comment.
Please provide return type hint for the function: take_input. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file knapsack/recursive_approach_knapsack.py, please provide doctest for the function take_input
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def knapsack(weights: list, values: list, n: int, max_weight: int, index: int) -> int: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
Updated the code
algorithms-keeper
bot
removed
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return max(ans1, ans2) | ||
|
|
||
|
|
||
| def take_input() -> tuple[list, list, int, int]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file knapsack/recursive_approach_knapsack.py, please provide doctest for the function take_input
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return max(ans1, ans2) | ||
|
|
||
|
|
||
| def take_input() -> tuple[list, list, int, int]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file knapsack/recursive_approach_knapsack.py, please provide doctest for the function take_input
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
awaiting reviews
|
Please do not open new pull requests in this repo until November 1st. 2022. |
Added a new naïve recursive approach to solve the knapsack problem.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.