Skip to content

Follow Flake8 pep3101 and remove modulo formatting #7339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2022

Conversation

CaedenPH
Copy link
Contributor

Describe your change:

Follow Flake8 pep3101 and remove modulo formatting (replace with f-strings)

For example

"Hello %s" % name

goes to

f"Hello {name}"
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 16, 2022
@cclauss
Copy link
Member

cclauss commented Oct 16, 2022

pyupgrade does a lot of this but flynt is more aggressive. There was some talk about NOT doing f-strings in exceptions.

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Oct 16, 2022

Damn, would've been useful to find this before I did it all manually.
Still, would be good to add this to pre-commit. Not sure what this talk about f-strings in exceptions is about

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 16, 2022
@cclauss cclauss merged commit f15cc2f into TheAlgorithms:master Oct 16, 2022
@CaedenPH CaedenPH deleted the flake8-pep3101 branch October 16, 2022 20:50
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants