Fixes : #6551 #6956
Fixes : #6551 #6956
Conversation
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| all_data.describe() | ||
|
|
||
| all_data['cabin_mul']=all_data.Cabin.apply(lambda x: 0 if pd.isna(x) else len(x.split(' '))) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
| all_data.describe() | ||
|
|
||
| all_data['cabin_mul']=all_data.Cabin.apply(lambda x: 0 if pd.isna(x) else len(x.split(' '))) | ||
| all_data['cabin_adv'] = all_data.Cabin.apply(lambda x: str(x)[0]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
|
|
||
| all_data['cabin_mul']=all_data.Cabin.apply(lambda x: 0 if pd.isna(x) else len(x.split(' '))) | ||
| all_data['cabin_adv'] = all_data.Cabin.apply(lambda x: str(x)[0]) | ||
| all_data['name_title']= all_data.Name.apply(lambda x: x.split(',')[1].split('.')[0].strip()) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
| all_dummies_scaled[['Age','SibSp','Parch','norm_fare']]= scale.fit_transform(all_dummies_scaled[['Age','SibSp','Parch','norm_fare']]) | ||
| all_dummies_scaled.head() | ||
|
|
||
| X_train_scaled = all_dummies_scaled[all_dummies_scaled.train_test == 1].drop(['train_test'], axis =1) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_train_scaled
| all_dummies_scaled.head() | ||
|
|
||
| X_train_scaled = all_dummies_scaled[all_dummies_scaled.train_test == 1].drop(['train_test'], axis =1) | ||
| X_test_scaled = all_dummies_scaled[all_dummies_scaled.train_test == 0].drop(['train_test'], axis =1) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_test_scaled
machine_learning/xgboostregressor.py
Outdated
| train=pd.read_csv('/kaggle/input/house-prices-advanced-regression-techniques/train.csv') | ||
|
|
||
| trainAmes.columns = trainAmes.columns.str.replace(' ', '') | ||
| trainAmes=trainAmes.rename(columns={"YearRemod/Add": "YearRemodAdd"}) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: trainAmes
machine_learning/xgboostregressor.py
Outdated
| len(duplicate) | ||
|
|
||
| duplicate=duplicate[0:390] | ||
| trainAmes = trainAmes.drop(duplicate, axis = 0) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: trainAmes
machine_learning/xgboostregressor.py
Outdated
| train_test_dummy = pd.get_dummies(train_test) | ||
|
|
||
| numeric_features = train_test_dummy.dtypes[train_test_dummy.dtypes != object].index | ||
| skewed_features = train_test_dummy[numeric_features].apply(lambda x: skew(x)).sort_values(ascending=False) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
|
|
||
| # Train-Test separation | ||
|
|
||
| X_train = train_test_dummy[0:4000] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_train
| # Train-Test separation | ||
|
|
||
| X_train = train_test_dummy[0:4000] | ||
| X_test = train_test_dummy[4000:] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_test
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| all_data.describe() | ||
|
|
||
| all_data["cabin_mul"] = all_data.Cabin.apply( | ||
| lambda x: 0 if pd.isna(x) else len(x.split(" ")) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
| all_data["cabin_mul"] = all_data.Cabin.apply( | ||
| lambda x: 0 if pd.isna(x) else len(x.split(" ")) | ||
| ) | ||
| all_data["cabin_adv"] = all_data.Cabin.apply(lambda x: str(x)[0]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
| ) | ||
| all_data["cabin_adv"] = all_data.Cabin.apply(lambda x: str(x)[0]) | ||
| all_data["name_title"] = all_data.Name.apply( | ||
| lambda x: x.split(",")[1].split(".")[0].strip() |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
| ) | ||
| all_dummies_scaled.head() | ||
|
|
||
| X_train_scaled = all_dummies_scaled[all_dummies_scaled.train_test == 1].drop( |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_train_scaled
| X_train_scaled = all_dummies_scaled[all_dummies_scaled.train_test == 1].drop( | ||
| ["train_test"], axis=1 | ||
| ) | ||
| X_test_scaled = all_dummies_scaled[all_dummies_scaled.train_test == 0].drop( |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_test_scaled
| ) | ||
|
|
||
| trainAmes.columns = trainAmes.columns.str.replace(" ", "") | ||
| trainAmes = trainAmes.rename(columns={"YearRemod/Add": "YearRemodAdd"}) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: trainAmes
| len(duplicate) | ||
|
|
||
| duplicate = duplicate[0:390] | ||
| trainAmes = trainAmes.drop(duplicate, axis=0) |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: trainAmes
| numeric_features = train_test_dummy.dtypes[train_test_dummy.dtypes != object].index | ||
| skewed_features = ( | ||
| train_test_dummy[numeric_features] | ||
| .apply(lambda x: skew(x)) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
|
|
||
| # Train-Test separation | ||
|
|
||
| X_train = train_test_dummy[0:4000] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_train
| # Train-Test separation | ||
|
|
||
| X_train = train_test_dummy[0:4000] | ||
| X_test = train_test_dummy[4000:] |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_test
|
Please review my PR and add the hacktoberfest tag. |
|
Please read our |
|
Please read the file |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.