Skip to content

Fix iter_merge_sort bug #6153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2022
Merged

Fix iter_merge_sort bug #6153

merged 4 commits into from
May 21, 2022

Conversation

dangbb
Copy link
Contributor

@dangbb dangbb commented May 16, 2022 •
edited by poyea
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$6152}.

Fixes #6152

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 16, 2022
@dangbb dangbb changed the title Fixed bug where array length 2 can't be sorted Fixes: #{$6152} May 16, 2022
@dangbb
Add MCC and DU path test
d087b16 
Add test to conversions/octal_to_decimal.py and sorts\iterative_merge_sort.py
@dangbb
Copy link
Contributor Author

dangbb commented May 17, 2022

I also do addition testing for conversions\octal_to_decimal.py.

Test Report - add MCC and DU path test.pdf

Here is the document about MCC and DU path for testing conversions\octal_to_decimal.py.

@ghost ghost added the tests are failing Do not merge until tests pass label May 20, 2022
@poyea poyea changed the title Fixes: #{$6152} Fix iter_merge_sort bug May 20, 2022
@poyea poyea self-assigned this May 20, 2022
@poyea
Copy link
Member

poyea commented May 20, 2022

Thanks @dangbb Please fix the pre-commit issue?

@ghost ghost removed the tests are failing Do not merge until tests pass label May 21, 2022
@dangbb
Copy link
Contributor Author

dangbb commented May 21, 2022

Thank @poyea , I have fixed the pre-commit issue. Please give it a check.

poyea
poyea approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 21, 2022
@poyea poyea merged commit 5bac76d into TheAlgorithms:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function iter_merge_sort has bug where array with length 2 is not sorted
2 participants
@dangbb @poyea