Skip to content

Update sorts/bubble_sort.py #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Update sorts/bubble_sort.py #5802

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8cd8a
Add missing type annotations in bubble_sort.py
dylanbuchi Nov 10, 2021
8c07864
Refactor bubble_sort function
dylanbuchi Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor bubble_sort function
  • Loading branch information
@dylanbuchi
dylanbuchi committed Nov 10, 2021
commit 8c07864507c9dc7f68755b6645cd5ce33e57da0a
4 changes: 2 additions & 2 deletions sorts/bubble_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ def bubble_sort(collection: list[Any]) -> list[Any]:
True
"""
length = len(collection)
for i in range(length - 1):
for i in reversed(range(length)):
Copy link
Member

@l3str4nge l3str4nge Nov 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is calling reversed more efficient? I don't think so. Did you do some benchmarks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reversed has to be a bit better since the Python heapq.py module uses it.
It also improves code readability. @l3str4nge

Source: https://www.python.org/dev/peps/pep-0322/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but it would be good to know if algorithms performance is better too :) Could you perform any benchmarks before and after refactor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarked with the timeit module:

1000 items:

Before: 
0.10902250000071945

After: 
0.11019620000297436

5000 items:

Before: 
2.8898907999973744

After: 
2.844012000001385

10000 items:

Before: 
12.34897049999563

After: 
11.655540399995516

I tested a bit more locally and sometimes refactored one is better and sometimes it's the original.

swapped = False
for j in range(length - 1 - i):
for j in range(i):
if collection[j] > collection[j + 1]:
swapped = True
collection[j], collection[j + 1] = collection[j + 1], collection[j]
Expand Down