-
-
Notifications
You must be signed in to change notification settings - Fork 47.1k
Delete other/date_to_weekday.py as a how-to-use, not an algorithm #5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cclauss
merged 6 commits into
TheAlgorithms:master
from
spazm:mypy-fix-other-date_to_weekday
Oct 29, 2021
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59a3523
[mypy] Fixes typing errors in other/date_to_weekday
spazm 4bbe7ab
[mypy] uses future annotation style for other/date_to_weekly
spazm 4c2425a
date_to_weekday: new implementation replaces buggy original
spazm a053227
date_to_weekday: add examples from multiple of 100 years
spazm b9fee14
clean-up: runs `black` to fix formatting
spazm 7f8f2e3
Delete date_to_weekday.py
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
date_to_weekday: new implementation replaces buggy original
- Loading branch information
commit 4c2425a8d910e263c48e9e8eb84191dd3b6fa1de
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep a full implementation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My sense is that we should delete the entire file. This is a how-to-use the datetime module, not an algorithm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we already have https://github.com/TheAlgorithms/Python/blob/master/other/doomsday.py