Skip to content

Modified Euler's Method #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 14, 2021
Merged

Modified Euler's Method #5258

merged 17 commits into from
Oct 14, 2021

Conversation

AMANKANOJIYA
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

AMANKANOJIYA and others added 10 commits October 11, 2021 08:24
Core function to find Magnitude and Angle of two Given Vector
added Doctest to the functions
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
and Magnitude and Angle Issues
Adding Modified Euler's method, which was the further change to a Euler method and known for better accuracy to the given value
Modified function is used for better accuracy
Added link to an explanation as per Contributions Guidelines
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 12, 2021
@AMANKANOJIYA
Copy link
Contributor Author

@Kush1101 @cclauss Required Review

@cclauss
Copy link
Member

cclauss commented Oct 13, 2021

Please look at and fix the failing tests before requesting a review. We started Hacktoberfest with 10 open PRs and we now have 160 open PRs so we will not dedicate much time to reviewing PRs that have failing tests.

@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 13, 2021
@AMANKANOJIYA
Copy link
Contributor Author

Please look at and fix the failing tests before requesting a review. We started Hacktoberfest with 10 open PRs and we now have 160 open PRs, so we will not dedicate much time to reviewing PRs that have failing tests.

okay sir now I think I resolved all the problem from my side you can pls review now

@AMANKANOJIYA
Copy link
Contributor Author

@cclauss Now You can Review

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 14, 2021
@cclauss cclauss merged commit 9b4cb05 into TheAlgorithms:master Oct 14, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Magnitude and Angle 

Core function to find Magnitude and Angle of two Given Vector

* Magnitude and Angle with Doctest

added Doctest to the functions

* Update linear_algebra/src/lib.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update linear_algebra/src/lib.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Changes done 

and Magnitude and Angle Issues

* black

* Modified Euler's Method

Adding Modified Euler's method, which was the further change to a Euler method and known for better accuracy to the given value

* Modified Euler's Method (changed the typing of function)

Modified function is used for better accuracy

* Link added

Added link to an explanation as per Contributions Guidelines

* Resolving Pre-Commit error

* Pre-Commit Error Resolved

* Pre-Commit Error import statement Change

* Removed Import Math

* import math built issue

* adding space pre-commit error

* statement sorter for doc

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants