Skip to content

There is an invalid case also in Knapsack. #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

There is an invalid case also in Knapsack. #4911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions knapsack/knapsack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ def knapsack(capacity: int, weights: list[int], values: list[int], counter: int)
which is the limit of the capacity.
"""

# Invalid Case
if len(val)!=len(w):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please recheck the variable name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do i do that now. Can you please suggest me. Should i create new PR or what. Really new here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you can see if knapsack called like knapsack(cap, w, val, c) then knapsack function accept the variables to named capacity, weights, values and counter.
so, there is no val and w now but only use values and weights.
then now you can code like this -> if len(values) != len(weights)

return -1

# Base Case
if counter == 0 or capacity == 0:
return 0
Expand Down