Refresh PR #2216 #3881
Closed
Refresh PR #2216 #3881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a while since I worked with typed python, forgive me ok?
I am not sure it the calculate_chain doctest works, since they are testing the side effects of the function, we will see what CI thinks of it
noone gave a good reason on why to remove it, and since this file is executable anyway (and thus easier to run for me)
doctests reset the environment after each function evaluation, so we can't use doctests to inspect side effects of void functions
… master # Conflicts: # project_euler/problem_014/sol3.py
Turns out that we don't do any doctests here anymore, we just write our oWN FRAMEWORK NOW DO WE?!
|
run the following commands in order:
commit and push the changes to your fork. |
Author
|
Consider it fixed |
|
@dhruvmanila, please check this. |
kbakdev
approved these changes
Nov 19, 2020
ghost
approved these changes
Nov 19, 2020
Member
|
Thank you for your contribution but currently, we're not accepting solutions to problems that already exist. Try to solve a problem which is not present in the directory and submit a PR for that. |
|
shall we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
See #2216
Checklist:
Fixes: #{$ISSUE_NO}.