Skip to content

Created problem_45 in project_euler and Speed Boost for problem_34/sol1.py #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 25, 2020
Merged

Created problem_45 in project_euler and Speed Boost for problem_34/sol1.py #2349

merged 13 commits into from
Aug 25, 2020

Conversation

Kush1101
Copy link
Member

@Kush1101 Kush1101 commented Aug 25, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
@Kush1101 @cclauss
Update project_euler/problem_45/sol1.py
4bb67a0 
Co-authored-by: Christian Clauss <cclauss@me.com>
@Kush1101 Kush1101 requested a review from cclauss August 25, 2020 08:21
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 542a6260-e6be-11ea-aa37-f5f007553843

cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
Kush1101 and others added 2 commits August 25, 2020 16:49
@Kush1101 @cclauss
Update project_euler/problem_34/sol1.py
42c1887 
Co-authored-by: Christian Clauss <cclauss@me.com>
@Kush1101 @cclauss
Update project_euler/problem_34/sol1.py
136b05a 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
@TravisBuddy
Copy link

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 508d6150-e6c5-11ea-aa37-f5f007553843

@Kush1101 Kush1101 changed the title Created problem_45 in project_euler Created problem_45 in project_euler and Speed Boost for problem_34/sol1.py Aug 25, 2020
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
@Kush1101 @cclauss
Update project_euler/problem_34/sol1.py
f38caae 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
Kush1101 and others added 2 commits August 25, 2020 16:59
@Kush1101
Update sol1.py
3b8fd2f
@Kush1101 @cclauss
Update project_euler/problem_34/sol1.py
ae70537 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
cclauss
cclauss reviewed Aug 25, 2020
View reviewed changes
@cclauss cclauss merged commit 402ba7f into TheAlgorithms:master Aug 25, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @cclauss @stokhos
Created problem_45 in project_euler and Speed Boost for problem_34/so…
56f7b81 
…l1.py (TheAlgorithms#2349)

* Create __init__.py

* Add files via upload

* Update sol1.py

* Update sol1.py

* Update project_euler/problem_45/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update sol1.py

* Update sol1.py

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update sol1.py

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update sol1.py

* Update project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kush1101 @TravisBuddy @cclauss