Skip to content

Added Normalization and Standardization Algorithms #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2020
Merged

Added Normalization and Standardization Algorithms #2192

merged 2 commits into from
Jul 10, 2020

Conversation

danmurphy1217
Copy link
Contributor

Describe your change:

Replace #2191

  • Add an algorithm?
  • [] Fix a bug or typo in an existing algorithm?
  • [] Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@danmurphy1217 danmurphy1217 changed the title Added Standardization and Normalization Algorithms Replace #2191 Jul 9, 2020
@danmurphy1217 danmurphy1217 changed the title Replace #2191 Added Normalization and Standardization Algorithms Jul 9, 2020
Sahith02
Sahith02 suggested changes Jul 10, 2020
View reviewed changes
Copy link

@Sahith02 Sahith02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one suggestion. Rather than rounding it to a hardcoded value of 3, wouldn't it be better to let the user pass the number of decimal places to round as a parameter to the functions?

cclauss
cclauss approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool submission. Thanks!

@TravisBuddy
Copy link

Travis tests have failed

Hey @danmurphy1217,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e4a395a0-c2b0-11ea-bbc7-2b020bbf5e3a

@cclauss cclauss merged commit 1f1c3b0 into TheAlgorithms:master Jul 10, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@danmurphy1217 @cclauss @stokhos
Added Normalization and Standardization Algorithms (TheAlgorithms#2192)
1b2af00 
* Added Standardization and Normalization algorithms with built-in stats

* Implement ndigits for rounding

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahith02 Sahith02 Sahith02 requested changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danmurphy1217 @TravisBuddy @cclauss @Sahith02