Skip to content

chore(geometry): add angle conversion, ellipse eccentricity, polygon geometry, and triangle class #13447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(geometry): add angle conversion, ellipse eccentricity, polygon geometry, and triangle class #13447

wants to merge 2 commits into from

Conversation

JeelGajera
Copy link
Contributor

Describe your change:

This PR adds several enhancements and new capabilities to the geometry module:

  • Add Angle.to_radians() and Angle.from_radians() conversions
  • Improve Ellipse.perimeter using Ramanujan’s approximation and add eccentricity property
  • Extend Polygon with:
    • get_vertices() to compute vertex coordinates
    • perimeter() and area() methods
  • Update Rectangle to build all 4 sides and integrate with the polygon logic
  • Introduce Triangle class:
    • Validate side lengths (triangle inequality)
    • Compute interior angles (if not provided)
    • Compute perimeter and area (Heron’s formula)
  • Add and adjust doctests for accuracy and coverage

These improvements expand the geometry module’s ability to model and calculate advanced shapes.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@JeelGajera
Copy link
Contributor Author

@cclauss please review this PR.

JeelGajera and others added 2 commits October 14, 2025 17:54
@JeelGajera
chore(geometry): add angle conversion, ellipse eccentricity, polygon …
bfe2375 
…geometry, and triangle class

- Added `Angle.to_radians()` and `Angle.from_radians()` for degree-radian conversion.
- Improved `Ellipse.perimeter` with Ramanujan’s approximation and added `eccentricity` property.
- Enhanced `Polygon` with vertex generation, perimeter, and area computation.
- Updated `Rectangle` to construct all four sides and support complete vertex/area logic.
- Introduced new `Triangle` class with validation, perimeter, and Heron’s area formula.
@pre-commit-ci @JeelGajera
[pre-commit.ci] auto fixes from pre-commit.com hooks
20a8115 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JeelGajera