Improved the Highest Common Divisor Algorithm #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of taking the difference at every step, one can use the remainder(since it is going to keep running until it reaches the point the value of x is smaller than y).
Improved Algorithm
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the two numbers have a huge difference, the algorithm will take too many steps to run. Instead, one can take the remainder and move to the next step directly. It is a considerable improvement in run time.
Also, in the issue, it is mentioned that the Greatest Common Divisor algorithm is missing. But, HCF and GCD are the same, so there should be no need for two different files with the same code. If you still want to have a separate file for Greatest Common Divisor, I can add it.
Would you please review and suggest if any changes are required?
PR for hacktoberfest, please add the label hacktoberfest-accepted.