Skip to content

Conversation

@Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Oct 19, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Other

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Panquesito7 Panquesito7 added the chore General improvement label Oct 19, 2022
@Panquesito7
Copy link
Member Author

Strange. Seems the Code style and tests part takes too long to run. 👀

@raklaptudirm
Copy link
Member

Strange. Seems the Code style and tests part takes too long to run. 👀

Thats why we run the full tests only on master. Closing because this is the correct functionality.

@Panquesito7 Panquesito7 deleted the workflow_prs branch November 4, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore General improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants