-
Notifications
You must be signed in to change notification settings - Fork 20.6k
feat(strings): add StringRotation to check if one string is a rotatio… #6759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(strings): add StringRotation to check if one string is a rotatio… #6759
Conversation
…n of another Signed-off-by: konduri-lakshmi-prasanna <konduriprasanna22@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6759 +/- ##
============================================
- Coverage 77.84% 77.83% -0.02%
- Complexity 6394 6397 +3
============================================
Files 733 734 +1
Lines 21333 21341 +8
Branches 4183 4184 +1
============================================
+ Hits 16607 16610 +3
- Misses 4058 4061 +3
- Partials 668 670 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All checks have passed successfully. |
1 similar comment
All checks have passed successfully. |
All checks have passed |
@konduri-lakshmi-prasanna Both deal with string rotation operations, but the existing class already defines rotation logic ( To keep the codebase organized and avoid duplicate classes, I’d suggest:
That way, all string rotation–related functionality stays in one class. Thank you. |
@konduri-lakshmi-prasanna have you read my comment? |
…n of another
clang-format -i --style=file path/to/your/file.java