Skip to content

Conversation

konduri-lakshmi-prasanna

…n of another

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

…n of another

Signed-off-by: konduri-lakshmi-prasanna <konduriprasanna22@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.83%. Comparing base (b312567) to head (3577b2f).

Files with missing lines Patch % Lines
...java/com/thealgorithms/strings/StringRotation.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6759      +/-   ##
============================================
- Coverage     77.84%   77.83%   -0.02%     
- Complexity     6394     6397       +3     
============================================
  Files           733      734       +1     
  Lines         21333    21341       +8     
  Branches       4183     4184       +1     
============================================
+ Hits          16607    16610       +3     
- Misses         4058     4061       +3     
- Partials        668      670       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@konduri-lakshmi-prasanna
Copy link
Author

All checks have passed successfully.
Requesting review and merge. Thank you!

1 similar comment
@konduri-lakshmi-prasanna
Copy link
Author

All checks have passed successfully.
Requesting review and merge. Thank you!

@konduri-lakshmi-prasanna
Copy link
Author

All checks have passed
Requesting review when possible. Thank you!

@DenizAltunkapan
Copy link
Member

@konduri-lakshmi-prasanna
This new class StringRotation seems closely related to the existing Rotation class.

Both deal with string rotation operations, but the existing class already defines rotation logic (rotation() and reverse() methods).
The proposed method isRotation() doesn’t introduce a new algorithmic concept — it’s a check built on top of the same rotation principle.

To keep the codebase organized and avoid duplicate classes, I’d suggest:

  • Renaming the existing class – instead of introducing a new class StringRotation,
  • Move the isRotation(String, String) method into the existing Rotation class

That way, all string rotation–related functionality stays in one class. Thank you.

@DenizAltunkapan
Copy link
Member

@konduri-lakshmi-prasanna have you read my comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants