feat: Add Hierholzer's Algorithm for Eulerian Circuits #6726
Conversation
sairamsharan
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6726 +/- ##
============================================
- Coverage 77.82% 77.81% -0.01%
- Complexity 6392 6410 +18
============================================
Files 732 733 +1
Lines 21320 21384 +64
Branches 4182 4200 +18
============================================
+ Hits 16592 16641 +49
- Misses 4059 4064 +5
- Partials 669 679 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sairamsharan
force-pushed
the
feat-hierholzer-algorithm
branch
from
cc180be to
568913c
Compare
sairamsharan
force-pushed
the
feat-hierholzer-algorithm
branch
from
d24cf14 to
96bd4fc
Compare
There was a problem hiding this comment.
@sairamsharan Thank you for your contribution. Please remove ChatGPT-like "FINAL FIX" comments.
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.Stack; | ||
|
|
There was a problem hiding this comment.
Please add proper JavaDoc comments explaining this algorithm, its purpose, and expected input (e.g., undirected graph), similar to other classes in the repository.
|
|
||
| private final Map<Integer, LinkedList<Integer>> graph; | ||
|
|
||
| public HierholzerAlgorithm(Map<Integer, LinkedList<Integer>> graph) { |
There was a problem hiding this comment.
Consider mentioning in JavaDoc that an undirected graph is expected, if it is so.
| tempGraph.get(nextVertex).remove(Integer.valueOf(currentVertex)); | ||
| currentPath.push(nextVertex); | ||
| } else { | ||
| circuit.add(0, currentPath.pop()); |
There was a problem hiding this comment.
Consider using LinkedList.addFirst() for better performance.
|
|
||
| dfs(startNode, visited); | ||
|
|
||
| // FINAL FIX: Use entrySet for efficiency. |
There was a problem hiding this comment.
why "FINAL FIX:" ? I think this comment might be confusing...
| List<Integer> circuit = new LinkedList<>(); | ||
|
|
||
| int startVertex = -1; | ||
| // FINAL FIX: Use entrySet for efficiency. |
There was a problem hiding this comment.
why "FINAL FIX:" ? I think this comment might be confusing...
3 participants
clang-format -i --style=file path/to/your/file.java