Feature: Show head & base ref, cap markdown headings to h4 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanogdev
commented
Jul 21, 2021
src/github.sh
Outdated
|
|
||
| github::get_pr_body() { | ||
| jq --raw-output .pull_request.body "$GITHUB_EVENT_PATH" | ||
| jq --raw-output .pull_request.body "$GITHUB_EVENT_PATH" | sed -r 's/#{1,3}/####/' |
Contributor
Author
There was a problem hiding this comment.
someone with more than cursory knowledge of sed might wanna take a look at this 😅
seanogdev
commented
Jul 21, 2021
|
|
||
| --- | ||
|
|
||
| ${pr_body//###/####} |
Contributor
Author
There was a problem hiding this comment.
Flexicon
approved these changes
Jul 22, 2021
Contributor
Flexicon
left a comment
Flexicon
left a comment
There was a problem hiding this comment.
It looks good to me, but I'm assuming you ran the bash scripts locally and made sure sed is doing what you want it to? 😅
Contributor
Author
act/docker is acting up actually... 2 secs |
Contributor
Author
|
Yep so act has a bug right now, tested the event directly
|
Contributor
|
Good enough for me! 👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the base and head branches. Found myself losing context sometimes & to avoid going between github & teamwork, I'd rather have the branch information in teamwork itself.
Also added the base ref, useful when working in a long standing feature branch
Finally, I've capped all headings to h4 , as the headings in teamwork's markdown are quite big