Skip to content

Conversation

@ychartois
Copy link
Contributor

Not everybody would like to have automatic tagging as it's tied to personal workflow. It perfect when your workflow follow the: 1 task = 1 PR, but it's not always the case.
By default the automatic tagging is turned off, if you want to enable it, you have to add it to your teamwork.yml like:

        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          TEAMWORK_URI: ${{ secrets.TEAMWORK_URI }}
          TEAMWORK_API_TOKEN: ${{ secrets.TEAMWORK_API_TOKEN }}
          AUTOMATIC_TAGGING: false

Fixes #33

Copy link
Contributor

@toffentoffen toffentoffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small doubt to discuss. In general LGTM

# Ensure env vars and args exist
ensure::env_variable_exist "GITHUB_REPOSITORY"
ensure::env_variable_exist "GITHUB_EVENT_PATH"
ensure::total_args 3 "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about checking if TEAMWORK_API_TOKEN exists as well? Isn't it mandatory as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to check it because it's already defined as mandatory in the YML file.

Copy link
Contributor

@miguelbemartin miguelbemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I didn't test locally.

@ychartois
Copy link
Contributor Author

I did test but might have miss something... anyway, the "Ensure this projects runs" is stuck since yesterday...

@miguelbemartin
Copy link
Contributor

I did test but might have miss something... anyway, the "Ensure this projects runs" is stuck since yesterday...

This is because this only runs when:

on:
  pull_request:
    types: [opened, closed]
  pull_request_review:
    types: [submitted, dismissed]

so if you update the PR, the workflow to test the action doesn't run again.

@miguelbemartin
Copy link
Contributor

@ychartois feel free to merge this PR.

Don't forget to add a "new release" after PR has been merged.

@miguelbemartin miguelbemartin merged commit f4d4ec1 into master Nov 27, 2020
@miguelbemartin miguelbemartin deleted the tag-worklow-optional branch November 27, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants