-
Notifications
You must be signed in to change notification settings - Fork 28
Have automatic tagging as an option #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
toffentoffen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small doubt to discuss. In general LGTM
| # Ensure env vars and args exist | ||
| ensure::env_variable_exist "GITHUB_REPOSITORY" | ||
| ensure::env_variable_exist "GITHUB_EVENT_PATH" | ||
| ensure::total_args 3 "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about checking if TEAMWORK_API_TOKEN exists as well? Isn't it mandatory as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to check it because it's already defined as mandatory in the YML file.
miguelbemartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I didn't test locally.
|
I did test but might have miss something... anyway, the "Ensure this projects runs" is stuck since yesterday... |
This is because this only runs when: so if you update the PR, the workflow to test the action doesn't run again. |
|
@ychartois feel free to merge this PR. Don't forget to add a "new release" after PR has been merged. |
Not everybody would like to have automatic tagging as it's tied to personal workflow. It perfect when your workflow follow the: 1 task = 1 PR, but it's not always the case.
By default the automatic tagging is turned off, if you want to enable it, you have to add it to your
teamwork.ymllike:Fixes #33