Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Issue #179 draft #598

Merged
merged 7 commits into from
Feb 25, 2021
Merged

Issue #179 draft #598

merged 7 commits into from
Feb 25, 2021

Conversation

fassko
Copy link
Member

@fassko fassko commented Feb 24, 2021

Closes #595

@hal-codebot
Copy link

hal-codebot commented Feb 24, 2021

1 Warning
⚠️ Looks like you're editing a draft! 🤓
Don't forget to review our style guide and publish the issue when you're finished.

Proselint found issues

_drafts/2021-02-25-issue-179.md

Line Message Severity
6 Annotation left in text. warning
7 Annotation left in text. warning
8 Annotation left in text. warning
9 Annotation left in text. warning
53 Inconsistent spacing after period (1 vs. 2 spaces). warning
54 Inconsistent spacing after period (1 vs. 2 spaces). warning
55 Inconsistent spacing after period (1 vs. 2 spaces). warning
61 Substitute 'damn' every time you're inclined to write 'very'; your editor will delete it and the writing will be just as it should be. Found once elsewhere. warning
96 Needless variant. 'extendable' is the preferred form. warning
96 Needless variant. 'extendable' is the preferred form. warning
104 Months should be capitalized. 'January' is the preferred form. warning

Generated by 🚫 Danger

@JaredHalpern
Copy link
Member

JaredHalpern commented Feb 25, 2021

@fassko I've added my suggested updates in a separate PR this week instead of directly editing the file. Let me know if that works. I feel more comfortable doing it this way rather than directly editing your file. :)

@morqon
Copy link
Member

morqon commented Feb 25, 2021

@fassko I've added my suggested updates in a separate PR this week instead of directly editing the file.

I'll add my changes to your PR @JaredHalpern, if that's ok. Then all copy edits can be merged in a single step.

* Update 2021-02-25-issue-179.md

* Update 2021-02-25-issue-179.md

* Copy edit (and minor Clubhouse expansion)

Small rewordings, and expanded the Clubhouse section with extra links to thank people involved.

Co-authored-by: Morgan <send.morgan@gmail.com>
Copy link
Member

@JaredHalpern JaredHalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@morqon morqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy edits and a quick scan of the link list, and looks good 👍🏻

@fassko fassko merged commit ccfbcd2 into main Feb 25, 2021
@fassko fassko deleted the issue_179 branch February 25, 2021 18:13
@fassko
Copy link
Member Author

fassko commented Feb 25, 2021

Thank you @JaredHalpern and @morqon! 🙏
I'm so happy to have you both.

@JaredHalpern
Copy link
Member

Happy to help :)

@morqon
Copy link
Member

morqon commented Feb 26, 2021

A pleasure!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[179] Issue #179 - February 25, 2021
4 participants