Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haptic Feedback #207

Closed
AbelToy opened this issue Aug 10, 2018 · 10 comments · Fixed by #484
Closed

Haptic Feedback #207

AbelToy opened this issue Aug 10, 2018 · 10 comments · Fixed by #484

Comments

@AbelToy
Copy link

AbelToy commented Aug 10, 2018

Maybe it would be a good idea to add some optional haptic feedback to certain alerts.

According to the human guidelines, there's three levels of feedback for notifications: success, warning and error.

At the moment it can be added using event listeners, but adding default support for it on specific configurations would be helpful

@AlbertoSamele
Copy link
Contributor

Will take care of this 👌👌

@mikestalker
Copy link

Hello. Any chance to get this PR merged?

@AlbertoSamele
Copy link
Contributor

@mikestalker it's been a long time since I made the PR so the branch eventually diverged, I will fix the conflicts this weekend so if it doesn't get merged and you really need my changes, you can just use my fork instead

@mikestalker
Copy link

Thx @AlbertoSamele. Just switched from NotificationBannerSwift to SwiftMessages and wanted get this haptic effect as it was in old library here as well. Not critical but nice to have for consistency.

@AlbertoSamele
Copy link
Contributor

Conflicts solved, my branch is now up to stream if you still want to use it @mikestalker

@mikestalker
Copy link

Thank you @AlbertoSamele . Hopefully your PR will be merged and released soon. Any chanse for that @wtmoose ?

@mikestalker
Copy link

@wtmoose can you please merge imrovements from @AlbertoSamele please?

@mikestalker
Copy link

@wtmoose any chanse to get haptic feedback PR merged?

wtmoose pushed a commit that referenced this issue Jan 23, 2024
@wtmoose
Copy link
Member

wtmoose commented Jan 23, 2024

Yeah. There were some problematic areas of the PR that prevented me from merging it. I went ahead and made the required updates. You can try it on the head of master

@mikestalker
Copy link

Thanks @AlbertoSamele , thanks @wtmoose
Works like a charm. Waiting for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants