ICP-3923 GoControl Integrations #2927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkirker
reviewed
Mar 20, 2018
| fingerprint mfr: "0060", prod: "0001", model: "0003", deviceJoinName: "Everspring Motion Sensor" // Everspring HSP02 | ||
| fingerprint mfr: "011A", prod: "0601", model: "0901", deviceJoinName: "Enerwave Motion Sensor" // Enerwave ZWN-BPC | ||
| fingerprint mfr: "0063", prod: "4953", model: "3133", deviceJoinName: "GE Portable Smart Motion Sensor" | ||
| fingerprint mfr: "014F", prod: "2002", model: "0203", deviceJoinName: "Linear PIR Motion Sensor" |
Contributor
There was a problem hiding this comment.
So... The device supports temperature. I noticed that it works fine with the Z-Wave Plus Motion/Temp Sensor, if state.sec gets set to 0 (it defaults to secure if state.sec is undefined -- I tested with an installed() that set state.sec-0). Maybe we could not use state.sec and just read the z-wave raw data for 's' and use this fingerprint with that DTH?
cc: @mckeed
Contributor
Author
There was a problem hiding this comment.
Yeah that's the old method of checking security I think. It's what got us in trouble with the Fibaro Smoke Sensor.
Update security handling
Contributor
Author
|
Moved the PIR sensor and updated the security handling. |
Contributor
Author
|
@dkirker ping |
dkirker
approved these changes
Apr 3, 2018
Contributor
|
the non-fingerprint change is in zwave-plus-motion-temp-sensor.groovy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.