-
Notifications
You must be signed in to change notification settings - Fork 1
Core: Added base code and tests #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
8697881 to
5ba3906
Compare
|
@coderabbitai review |
|
Warning Rate Limit Exceeded@Seluj78 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 22 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update introduces a comprehensive suite of enhancements to a Python project, focusing on automation, code quality, and testing. It establishes workflows for building packages, deploying releases, and running tests across multiple environments. Additionally, it configures pre-commit hooks for better code practices and introduces a custom exception for handling API errors. The project's documentation and testing strategies are also set for future improvements, marking a significant leap towards a more robust and developer-friendly codebase. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
codecov.ymlis excluded by:!**/*.ymlpyproject.tomlis excluded by:!**/*.tomltox.iniis excluded by:!**/*.ini
Files selected for processing (14)
- .github/workflows/build_pkg.yml (1 hunks)
- .github/workflows/deploy.yml (1 hunks)
- .github/workflows/tests.yml (1 hunks)
- .pep8speaks.yml (1 hunks)
- .pre-commit-config.yaml (1 hunks)
- README.md (2 hunks)
- requirements-dev.txt (1 hunks)
- shellhub/init.py (1 hunks)
- shellhub/exceptions.py (1 hunks)
- shellhub/models/base.py (1 hunks)
- shellhub/models/device.py (1 hunks)
- tests/conftest.py (1 hunks)
- tests/test_base.py (1 hunks)
- tests/test_devices.py (1 hunks)
Files skipped from review due to trivial changes (1)
- shellhub/init.py
Additional comments: 13
shellhub/exceptions.py (1)
- 1-2: LGTM!
requirements-dev.txt (1)
- 4-16: LGTM!
.pep8speaks.yml (1)
- 1-4: LGTM!
.github/workflows/build_pkg.yml (1)
- 1-32: LGTM!
.pre-commit-config.yaml (1)
- 24-34: LGTM!
.github/workflows/deploy.yml (1)
- 1-36: LGTM!
tests/test_base.py (1)
- 1-37: LGTM!
.github/workflows/tests.yml (1)
- 1-55: LGTM!
tests/conftest.py (1)
- 1-55: LGTM!
README.md (1)
- 93-106: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [3-106]
LGTM!
shellhub/models/base.py (1)
- 1-126: LGTM!
shellhub/models/device.py (1)
- 1-128: LGTM!
tests/test_devices.py (1)
- 1-279: LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (8)
- shellhub/init.py (1 hunks)
- shellhub/exceptions.py (1 hunks)
- shellhub/models/base.py (1 hunks)
- shellhub/models/device.py (1 hunks)
- tests/conftest.py (1 hunks)
- tests/test_base.py (1 hunks)
- tests/test_devices.py (1 hunks)
- tests/utils.py (1 hunks)
Files skipped from review due to trivial changes (1)
- tests/utils.py
Files skipped from review as they are similar to previous changes (5)
- shellhub/models/base.py
- shellhub/models/device.py
- tests/conftest.py
- tests/test_base.py
- tests/test_devices.py
Additional comments: 2
shellhub/exceptions.py (1)
- 1-14: The custom exception classes are correctly defined and follow Python's naming conventions for exceptions. Inheritance is properly used to create a hierarchy of exceptions. This setup allows for more granular exception handling in the project.
shellhub/__init__.py (1)
- 4-21: The import statements and the
__all__list are correctly updated to include the new exception classes, ensuring they are properly exported from theshellhubpackage. The version is appropriately set for the initial release.
8679a0d to
ad99a1a
Compare
Ignore the version update check as this is the first version so it will be the first release
Summary by CodeRabbit
ShellHubApiErrorclass for better error management in the ShellHub system.