feat: support alternative AD backends in linearization #3477
+136
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Mar 20, 2025
baggepinnen
approved these changes
Mar 20, 2025
baggepinnen
reviewed
Mar 20, 2025
|
Test failures |
gdalle
reviewed
Mar 21, 2025
| T = p isa MTKParameters ? eltype(p.tunable) : eltype(p) | ||
| hp_jac = PreparedJacobian{true}( | ||
| hp_fun, zeros(T, size(outputs)), autodiff, inputvals, | ||
| DI.Constant(prob.u0), DI.Constant(p), DI.Constant(t0)) |
There was a problem hiding this comment.
You might want to use DI.ConstantOrCache for the parameter p if it contains storage where active data gets written
There was a problem hiding this comment.
It's never written to. setter is out of place.
There was a problem hiding this comment.
Ok good, the same remark holds for other uses of Constant but I guess it gets the same answer. Just asking because we had the issue in OrdinaryDiffEq
There was a problem hiding this comment.
I appreciate the review nonetheless! It's nice to be doubly sure this is correct
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
AayushSabharwal
force-pushed
the
as/linearize-ad
branch
from
9b61cae to
d448fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.