Skip to content

feat: handle Initial(x) initialization_eqs in time-independent systems #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 20, 2025
Merged

feat: handle Initial(x) initialization_eqs in time-independent systems #3466

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
41ce7f5
fix: remove extra print statements
AayushSabharwal Mar 17, 2025
16ac26f
feat: add `Initial` parameters for unknowns to all non-initialization…
AayushSabharwal Mar 17, 2025
d3a5386
feat: handle `Initial(x)` initialization_eqs for time-independent sys…
AayushSabharwal Mar 17, 2025
ff7d28d
test: test `Initial(x)` initialization_eqs for time-independent systems
AayushSabharwal Mar 17, 2025
3e58b5a
Update src/systems/problem_utils.jl
ChrisRackauckas Mar 17, 2025
25159b8
refactor: remove extra empty file
AayushSabharwal Mar 17, 2025
f05b93f
build: bump DiffEqBase compat
AayushSabharwal Mar 18, 2025
d5e3d1a
feat: add `supports_initialization` trait
AayushSabharwal Mar 18, 2025
62b8c3c
fix: only add `Initial` parameters for systems that support initializ…
AayushSabharwal Mar 18, 2025
ca7b9c1
fix: handle cyclic `u0map` in some cases
AayushSabharwal Mar 18, 2025
bc0239c
test: update NonlinearSystem tests with new `Initial` parameters
AayushSabharwal Mar 18, 2025
b5cfedb
test: make hack tests more consistent
AayushSabharwal Mar 19, 2025
beb777a
fix: fix duplicated code running unconditionally
AayushSabharwal Mar 19, 2025
6dc3586
fix: only add observed equations to `u0map` for time-independent or i…
AayushSabharwal Mar 19, 2025
9335a5b
fix: fix `modelingtoolkitize(::NonlinearProblem)`
AayushSabharwal Mar 19, 2025
f276d4c
fix: add `add_additional_parameters` kwarg to `complete`
AayushSabharwal Mar 19, 2025
ec2fbb4
fix: don't add initial parameters in `ODEProblem(::JumpSystem)`
AayushSabharwal Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix duplicated code running unconditionally
  • Loading branch information
@AayushSabharwal
AayushSabharwal committed Mar 20, 2025
commit beb777a730b262cb59c205ee6758b1f140321e53
4 changes: 0 additions & 4 deletions src/systems/problem_utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,10 +706,6 @@ function maybe_build_initialization_problem(
empty!(missing_unknowns)
end

for v in missing_unknowns
op[v] = zero_var(v)
end
empty!(missing_unknowns)
return (;
initialization_data = SciMLBase.OverrideInitData(
initializeprob, update_initializeprob!, initializeprobmap,
Expand Down