Skip to content

[v10] refactor: use ImplicitDiscreteSystem to implement affects in callback systems #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 123 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
c4fa355
chore!: bump MAJOR version
AayushSabharwal Apr 14, 2025
d2e0821
ci: run workflows on PR to v10 branch
AayushSabharwal Apr 14, 2025
eb2e1fb
docs: bump MTK compat
AayushSabharwal Apr 14, 2025
6eba594
TEMP COMMIT: use branch of MTKStdlib
AayushSabharwal Apr 14, 2025
b976833
feat: make `@named` always wrap arguments in `ParentScope`
AayushSabharwal Apr 3, 2025
50451d2
test: test `@named` always wrapping in `ParentScope`
AayushSabharwal Apr 14, 2025
e0844d7
refactor: remove `DelayParentScope`
AayushSabharwal Apr 14, 2025
086bab6
refactor: remove `time_varying_as_func`
AayushSabharwal Apr 14, 2025
607c0a5
test: update tests with removed `time_varying_as_func`
AayushSabharwal Apr 14, 2025
cfc6cd7
refactor: remove input_idxs output
vyudu Apr 18, 2025
d3e8841
refactor: require simplify system for linearization
vyudu Apr 21, 2025
ea858ca
use mtkbuild
vyudu Apr 21, 2025
8cbbb16
fix: fix linearization tests
vyudu Apr 22, 2025
1f4243d
fix: simplify if not simplified
vyudu Apr 22, 2025
c424570
revert rename
vyudu Apr 22, 2025
6e3216e
revert more renames
vyudu Apr 22, 2025
22cdc69
correct tests
vyudu Apr 22, 2025
1956ca0
fix: require simplification again
vyudu Apr 22, 2025
5feffd8
reset test file
vyudu Apr 23, 2025
e6eab84
revert src/linearization
vyudu Apr 23, 2025
4e25363
reset doc file
vyudu Apr 23, 2025
f4723b8
revert rename
vyudu Apr 23, 2025
81fc5b5
test: test updates
vyudu Apr 24, 2025
a86e553
fix input output tests
vyudu Apr 24, 2025
e31b6a7
more test fixes
vyudu Apr 25, 2025
f1b7ceb
fix: fix sort_eqs and check distrubances in markio
vyudu Apr 28, 2025
47b7dd8
format
vyudu May 2, 2025
0cf319c
init
vyudu Mar 1, 2025
37f050e
refactor: refactor affect codegen
vyudu Mar 3, 2025
9795eeb
feat: correct affect system generation
vyudu Mar 5, 2025
811a42a
use Pre in the affect definition
vyudu Mar 10, 2025
60d5369
refactor: correct condition generation in
vyudu Mar 11, 2025
0e9215f
some tests working
vyudu Mar 12, 2025
66afd66
fix: modify constructor for SDESystem and JUmpSystem
vyudu Mar 12, 2025
627fbe0
test: make more tests pass
vyudu Mar 12, 2025
f3fe987
test: fix namespacing
vyudu Mar 12, 2025
e6abcd4
fix: fix JumpSystem and don't use is_diff_equation
vyudu Mar 12, 2025
1e15e74
typo: add )
vyudu Mar 12, 2025
c462dfc
typo: algeeqs
vyudu Mar 12, 2025
cdf3a6d
fix
vyudu Mar 14, 2025
72421e7
more test fixes
vyudu Mar 17, 2025
a57df9d
refactor: make iv, algeeqs kwargs
vyudu Mar 18, 2025
e10e5e4
fix NoInit() error
vyudu Mar 18, 2025
095b6b6
fix: fix initialization and finalization affects
vyudu Mar 20, 2025
4247831
uncomment tests
vyudu Mar 20, 2025
ed98038
fix: most tests passing
vyudu Mar 20, 2025
f1b6535
feat: add optimization for explicit affects
vyudu Mar 22, 2025
b7a4502
fix: fix FMI tests and parameter dependency tests
vyudu Mar 22, 2025
0d08ea1
more test fixes
vyudu Mar 22, 2025
4f9dfea
fix: more tests passing
vyudu Mar 24, 2025
ee65a30
fix: more test fixes
vyudu Mar 24, 2025
0e8b48d
fix: use is_diff_equation instead of isdiffeq when finding algeeqs
vyudu Mar 24, 2025
b595375
feat: specify discrete_parameters
vyudu Mar 25, 2025
b9669c1
up
vyudu Mar 26, 2025
8625744
feat: add discrete_parameters
vyudu Mar 26, 2025
990eb7b
fix: use is_diff_equation with flatten_equations
vyudu Mar 26, 2025
479e147
remove show
vyudu Mar 26, 2025
60a6a53
format
vyudu Mar 26, 2025
94d172c
fix: fix typos and to_term differentials in affect equations
vyudu Mar 27, 2025
9e11381
fix: add events to SDESystem after structural simplification
vyudu Mar 27, 2025
831a8d7
fix: add reinitalizealg back
vyudu Mar 28, 2025
deb4e31
fix: use discrete_parameters in tests
vyudu Mar 31, 2025
9b356db
fix: fix collect_var
vyudu Mar 31, 2025
661e1f6
format
vyudu Mar 31, 2025
4d1e8b7
docs: add documentation for the symbolic affect changes
vyudu Apr 1, 2025
00ccca4
revert index cache
vyudu Apr 1, 2025
7b4058b
fix: use discrete_parameters in SII test
vyudu Apr 1, 2025
8d0454c
fix: fix model parsing for events
vyudu Apr 1, 2025
3c036b0
docs: document the discrete_parameters
vyudu Apr 1, 2025
7295caa
format
vyudu Apr 1, 2025
9e12c83
fix: remove the plural constructors
vyudu Apr 1, 2025
84903a5
fix: fix model parsing error
vyudu Apr 2, 2025
0c09dd0
fix: add continuous_events back
vyudu Apr 2, 2025
50e9368
fix: allow Arr in tovar
vyudu Apr 2, 2025
45ec229
fix: allow Arr in tovar
vyudu Apr 2, 2025
57dd747
fix JumpSystem
vyudu Apr 2, 2025
c6e7fdb
fix: unwrap s in tovar
vyudu Apr 2, 2025
692c089
up
vyudu Apr 2, 2025
f5f5a88
fix: fix several tests
vyudu Apr 2, 2025
d95aa83
docs: fix doc discrete_events example
vyudu Apr 2, 2025
0b344eb
docs: fix doc example
vyudu Apr 2, 2025
4e8c752
docs: fix more doc examples
vyudu Apr 2, 2025
710fb4a
allow symbolic in Discrete condition
vyudu Apr 2, 2025
19e4368
require Bool
vyudu Apr 2, 2025
b34c766
more docs fixes
vyudu Apr 3, 2025
f682cac
update NewsMD
vyudu Apr 21, 2025
79278a2
fix: fix sfmi bugs and
vyudu Apr 22, 2025
04b86db
fix remaining tests
vyudu Apr 23, 2025
589e20e
format
vyudu Apr 23, 2025
29cdece
fix: improve performance of implicit_affect
vyudu Apr 29, 2025
b726810
fix: fix implicit_affect
vyudu Apr 29, 2025
f556dc5
format
vyudu Apr 29, 2025
44cf0fd
fix: improve performance of implicit affect
vyudu Apr 30, 2025
9c7c597
fix: drop alg_eqs for JumpSystem
vyudu Apr 30, 2025
d2ec633
fix: fix jumpsystem test
vyudu Apr 30, 2025
15dc5e2
format
vyudu Apr 30, 2025
115b8db
fix: fix SII issue in the implicit affect
vyudu May 1, 2025
26537d1
cleanup
vyudu May 1, 2025
5409f2b
fix: typo and setsym error
vyudu May 1, 2025
9ed02ce
rebase callback
vyudu May 5, 2025
985b8ae
chore!: bump MAJOR version
AayushSabharwal Apr 14, 2025
5af08a4
ci: run workflows on PR to v10 branch
AayushSabharwal Apr 14, 2025
0fbd4ee
docs: bump MTK compat
AayushSabharwal Apr 14, 2025
2f4112e
TEMP COMMIT: use branch of MTKStdlib
AayushSabharwal Apr 14, 2025
138c568
feat: make `@named` always wrap arguments in `ParentScope`
AayushSabharwal Apr 3, 2025
f603e8c
test: test `@named` always wrapping in `ParentScope`
AayushSabharwal Apr 14, 2025
c13fe32
refactor: remove `DelayParentScope`
AayushSabharwal Apr 14, 2025
b6b35af
refactor: remove `time_varying_as_func`
AayushSabharwal Apr 14, 2025
faa5bbf
test: update tests with removed `time_varying_as_func`
AayushSabharwal Apr 14, 2025
26292ff
refactor: remove input_idxs output
vyudu Apr 18, 2025
21b231a
refactor: use new `structural_simplify` in linearization
vyudu Apr 21, 2025
1d2a604
fix: fix linearization tests
vyudu Apr 22, 2025
c124625
test: test updates
vyudu Apr 24, 2025
70e25e8
fix input output tests
vyudu Apr 24, 2025
48ae093
more test fixes
vyudu Apr 25, 2025
0234315
fix: fix sort_eqs and check distrubances in markio
vyudu Apr 28, 2025
90aba86
test: fix input output test
AayushSabharwal May 7, 2025
0d7943d
test: fix usage of old `structural_simplify` io syntax
AayushSabharwal May 7, 2025
bdbf29a
Update src/parameters.jl
vyudu May 7, 2025
d6c2666
Update src/systems/callbacks.jl
vyudu May 7, 2025
bc8c760
Merge branch 'v10' into callback
vyudu May 7, 2025
ca507df
fix compile condition error
vyudu May 8, 2025
426e6bb
disable cse
vyudu May 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
require Bool
  • Loading branch information
vyudu committed May 5, 2025
commit 19e43681e5492211f5bc35ef49a41d570e73d7e8
2 changes: 1 addition & 1 deletion src/systems/callbacks.jl
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ Arguments:
- alg_eqs: Algebraic equations of the system that must be satisfied after the callback occurs.
"""
struct SymbolicDiscreteCallback <: AbstractCallback
conditions::Union{Number, Vector{<:Number}, Symbolic}
conditions::Union{Number, Vector{<:Number}, Symbolic{Bool}}
affect::Union{Affect, Nothing}
initialize::Union{Affect, Nothing}
finalize::Union{Affect, Nothing}
Expand Down