Skip to content

fix: separate Initial parameters into initials portion #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 5, 2025
Merged

fix: separate Initial parameters into initials portion #3439

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5567ab2
feat: separate initial parameters for non-initialization-systems
AayushSabharwal Mar 4, 2025
b52ecc2
feat: add `Initials` portion to `MTKParameters`
AayushSabharwal Mar 4, 2025
e2251af
refactor: remove dead code
AayushSabharwal Mar 4, 2025
7f3b1e1
fix: properly handle initial parameters in `complete`
AayushSabharwal Mar 4, 2025
73fb137
fix: handle initial parameters in symbolic indexing
AayushSabharwal Mar 4, 2025
e563466
fix: handle initial parameters in codegen
AayushSabharwal Mar 4, 2025
793abb5
fix: fix calling `MTKParameters` functions with just tunables vector
AayushSabharwal Mar 4, 2025
ef5326b
fix: promote `Initials` portion in `ReconstructInitializeprob`
AayushSabharwal Mar 4, 2025
0c9f032
fix: promote `Initials` portion in `late_binding_update_u0_p`
AayushSabharwal Mar 4, 2025
d830ab2
fix: simplify `modelingtoolkitize`
AayushSabharwal Mar 4, 2025
d7da992
fix: return `GeneratedFunctionWrapper` from `generate_control_function`
AayushSabharwal Mar 4, 2025
43c3ccb
fix: support initials in adjoints
AayushSabharwal Mar 4, 2025
5647dee
test: mark test as not broken
AayushSabharwal Mar 4, 2025
d6b3f27
test: remove unnecessary wrapping of parameter vector
AayushSabharwal Mar 4, 2025
5186afd
test: test promotion of initials portion in `remake`
AayushSabharwal Mar 4, 2025
84f7309
test: remove splatting of parameter object
AayushSabharwal Mar 4, 2025
25d52da
test: test indexing of `Initials` portion
AayushSabharwal Mar 4, 2025
6686524
test: update mtkparameters tests with new portion
AayushSabharwal Mar 5, 2025
66ec113
fix: handle empty `reduce` in rrule
AayushSabharwal Mar 5, 2025
bde633c
build: bump SciMLStructures compat
AayushSabharwal Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: bump SciMLStructures compat 
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
  • Loading branch information
@AayushSabharwal @ChrisRackauckas
AayushSabharwal and ChrisRackauckas committed Mar 5, 2025
commit bde633c2d16169ccd6b0b28e28beda4b5466a401
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Reexport = "0.2, 1"
RuntimeGeneratedFunctions = "0.5.9"
SCCNonlinearSolve = "1.0.0"
SciMLBase = "2.75"
SciMLStructures = "1.0"
SciMLStructures = "1.7"
Serialization = "1"
Setfield = "0.7, 0.8, 1"
SimpleNonlinearSolve = "0.1.0, 1, 2"
Expand Down
Loading