feat: run trivial initialization in problem constructor #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/run-trivial-init
branch
from
b55a3c2 to
e526022
Compare
| @@ -753,7 +753,7 @@ function DiffEqBase.ODEProblem{iip, specialize}(sys::AbstractODESystem, u0map = | |||
| kwargs1 = merge(kwargs1, (; tstops)) | |||
| end | |||
|
|
|||
| return ODEProblem{iip}(f, u0, tspan, p, pt; kwargs1..., kwargs...) | |||
| return remake(ODEProblem{iip}(f, u0, tspan, p, pt; kwargs1..., kwargs...)) | |||
There was a problem hiding this comment.
this should at least be commented why it's done. It's a bit of an odd way to get there, but understand why
AayushSabharwal
force-pushed
the
as/run-trivial-init
branch
from
e526022 to
57cb89a
Compare
AayushSabharwal
force-pushed
the
as/run-trivial-init
branch
from
547c3ff to
af2a1e6
Compare
AayushSabharwal
force-pushed
the
as/run-trivial-init
branch
from
af2a1e6 to
c768c3e
Compare
ChrisRackauckas
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3290, #3410