Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assertions functionality #3364

Merged
merged 11 commits into from
Feb 10, 2025

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link
Contributor

@baggepinnen baggepinnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool :)

@AayushSabharwal
Copy link
Member Author

I think formatter fails because it needs a rebase. Will do that once the PR is approved.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review February 4, 2025 06:06
@ChrisRackauckas
Copy link
Member

This isn't causing a NaN in the non-debug? isoutofdomain could be used or NaN throws.

@AayushSabharwal
Copy link
Member Author

I thought we didn't want this in the non-debug? I can add it if we do

@ChrisRackauckas
Copy link
Member

You want a NaN but not an error, or you want isoutofdomain. Either way you need step rejections

@ChrisRackauckas ChrisRackauckas merged commit 0a5c1ce into SciML:master Feb 10, 2025
31 of 44 checks passed
@AayushSabharwal AayushSabharwal deleted the as/assertions branch February 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants