refactor: centralize all code generation #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `build_function_wrapper`
AayushSabharwal
force-pushed
the
as/refactor-codegen
branch
from
2a28b0e to
849a902
Compare
AayushSabharwal
force-pushed
the
as/refactor-codegen
branch
from
849a902 to
1fc081f
Compare
ChrisRackauckas
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging the upcoming CSE would require near-identical changes to all the places we do code generation. This PR centralizes all code generation to one function so that the transformations required can be done in one place.
Requires JuliaSymbolics/Symbolics.jl#1423 and (desperately) a format