add utilities and tests for disturbance modeling #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
force-pushed
the
gen_control
branch
from
fb63dd0 to
31059f4
Compare
baggepinnen
force-pushed
the
gen_control
branch
3 times, most recently
from
786c9ae to
1d2c5db
Compare
Comment on lines
+505
to
+525
| if disturbance_inputs !== nothing | ||
| # Disturbance inputs may or may not be included as inputs, depending on disturbance_argument | ||
| ps = setdiff(ps, disturbance_inputs) | ||
| end | ||
| if disturbance_argument | ||
| disturbance_inputs = (disturbance_inputs,) | ||
| else | ||
| disturbance_inputs = () | ||
| end |
There was a problem hiding this comment.
If disturbance_inputs !== nothing and disturbance_argument is false, the disturbance inputs won't be anywhere in the arguments to the function. Is this intentional?
There was a problem hiding this comment.
Yes, this is intentional, that's why there's a separate argument to control whether or not they are included as function arguments.
The usecase is state estimation where the disturbance input is unknown (like sun shining in through the window) and you'd like to estimate this using a state estimator
AayushSabharwal
approved these changes
Feb 7, 2025
|
the failures all seem unrelated? |
|
Yeah they're unrelated. I'll PR to fix some |
|
rebase so we can see the tests? |
Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> rm plot
baggepinnen
force-pushed
the
gen_control
branch
from
1d2c5db to
ceb9cdc
Compare
AayushSabharwal
approved these changes
Feb 21, 2025
ChrisRackauckas
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add utilities such as
generate_control_function.build_explicit_observed_functionandgenerate_control_functionalso add tests for disturbance-modeling workflows