Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow duplicate names #2938

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Disallow duplicate names #2938

merged 3 commits into from
Aug 8, 2024

Conversation

contradict
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #2883

@ChrisRackauckas @baggepinnen
Update src/systems/model_parsing.jl
99b0138 
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
@ChrisRackauckas ChrisRackauckas merged commit 9949180 into SciML:master Aug 8, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baggepinnen baggepinnen baggepinnen left review comments

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to create system where a parameter and variable have the same name
3 participants
@contradict @ChrisRackauckas @baggepinnen