Feature django logging #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Export logging middleware to be added in django app for logging capabilities * Write tests for logging in sample django app
alexpenev-s
reviewed
Jul 16, 2018
README.rst
Outdated
| Django | ||
| ^^^^^^ | ||
|
|
||
| For django logging you have to edit a couple of files: |
There was a problem hiding this comment.
Maybe without this line (like the sections above)
alexpenev-s
reviewed
Jul 16, 2018
README.rst
Outdated
| url('example/', include('example_app.urls')) | ||
| ] | ||
| **Note**: The library works with Django 2.x as well, the example is in an earlier version for python 2 compatibility. |
There was a problem hiding this comment.
There is an example to how to make it work in Django 2.x? Could we link it?
alexpenev-s
reviewed
Jul 16, 2018
conftest.py
Outdated
| if sys.version_info < (3, 5): | ||
| collect_ignore = ['tests/test_sanic_logging.py'] | ||
|
|
||
| os.environ['DJANGO_SETTINGS_MODULE'] = 'tests.django_logging.test_app.settings' |
There was a problem hiding this comment.
Is it possible to do this in the test only, because we don't need this env variable for the other tests.
alexpenev-s
reviewed
Jul 16, 2018
| import uuid | ||
|
|
||
| CORRELATION_ID_HEADERS = ['X-Correlation-ID', | ||
| CORRELATION_ID_HEADERS = ['x-Correlation-ID', |
There was a problem hiding this comment.
Why is this changed needed? I believe X-Correlation-ID is the standard name.
alexpenev-s
reviewed
Jul 16, 2018
| self._get_response = get_response | ||
|
|
||
| def __call__(self, request): | ||
| response = self.process_request(request) |
There was a problem hiding this comment.
response is always None right? Why is this check done here?
alexpenev-s
reviewed
Jul 16, 2018
| request.context[key] = value | ||
|
|
||
| def get(self, key, request): | ||
| return request.context.get(key) if request else None |
There was a problem hiding this comment.
Should the context be inited here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for logging in cf format for django framework.