Add sap to the distribution name #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpenev-s
reviewed
Dec 7, 2017
README.rst
Outdated
| :: | ||
|
|
||
| pip install -e cf-python-logging-support git+https://github.com/SAP/cf-python-logging-support.git | ||
| pip install -e sap_cf_logging git+https://github.com/SAP/cf-python-logging-support.git |
There was a problem hiding this comment.
Does this work, my pip install says -e needs to be followed by the url
There was a problem hiding this comment.
the idea is after this change is merged we change the command to use pypi
There was a problem hiding this comment.
pip install -e git+git://github.com/SAP/cf-python-logging-support.git#egg=sap_cf_logging
gvachkov
force-pushed
the
rename-distribution
branch
from
a6022ae to
11714eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.