Add support for Falcon web framework #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvachkov
reviewed
Mar 11, 2018
| This is needed in order to get the *correlation_id* generated at the beginning of the request or | ||
| fetched from the HTTP headers. | ||
|
|
||
| Falcon |
There was a problem hiding this comment.
Please add to the Features section the support for Falcon, I would suggest creating a bulleted list containing the supported frameworks.
| class FalconRequestReader(RequestReader): | ||
| def get_remote_user(self, request): | ||
| remote_user = defaults.UNKNOWN | ||
| http_auth = request.get_header('Authorization') |
There was a problem hiding this comment.
I would prefer not to parse auth headers into the logging lib, rather to support the most common authentication frameworks and the way they provide user info. I would suggest to read the user from the request context as expected to be set by falcon-auth authentication layer.
| class LoggingMiddleware: | ||
|
|
||
| def __init__(self, logger='cf.falcon.logger'): | ||
| self.logger = logger |
There was a problem hiding this comment.
The name logger suggest an object, but this is a name, can you name it like logger_name for better readability?
|
The Falcon support has been added via: #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Falcon by:
sap.cf_logging.falcon_logging.LoggingMiddlewareContext,RequestReader,ResponseReaderas adapter to Falconinitto initialize CF Logging with Falcon connectionTests have been added and the Readme has been updated with an example.
Since Falcon does not provide a global context like Flask (with
flask.g), it leverages thereqobject for context. Alog()method gets attached to thereqobject in the middleware to avoid the necessity to provideextrawith the request object for logging (like in thesanicimplementation).