Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow logarithmic amplification #715

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daalfox
Copy link

@daalfox daalfox commented Mar 14, 2025

Adds volume control in decibels discussed in #714

@daalfox
Copy link
Author

daalfox commented Mar 14, 2025

This is my first contribution on this crate. Just checking in with you about the general approach for this. Is it ok?

Copy link
Collaborator

@dvdsk dvdsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the choices you made however I think we can do better. Let me know what you think of the feedback.

Further more did you look at the resource Roderick linked in the issue? It features a slightly more involved calculation that leads to a nicer volume curve. We could use that instead or have both the current log and that nicer one.

@daalfox
Copy link
Author

daalfox commented Mar 14, 2025

Yeah I wanted to keep myself in the same page with you. I just skimmed through the article I will check it out. Thanks for review

@roderickvd
Copy link
Collaborator

roderickvd commented Mar 14, 2025

You can look at the code I linked to, which compresses that article into 10 lines of code. You can copy and/or modify those lines from me under public domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants