Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: elementAt, first - constrain upstream requests #6620

Merged
merged 5 commits into from
Aug 16, 2019

Conversation

davidmoten
Copy link
Collaborator

As discussed in #6569 this PR constrains upstream requests for the elementAt and first overloads. Other operators will be covered in other PRs.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #6620 into 3.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6620      +/-   ##
============================================
+ Coverage     98.13%   98.17%   +0.03%     
- Complexity     6187     6188       +1     
============================================
  Files           678      678              
  Lines         44792    44792              
  Branches       6173     6173              
============================================
+ Hits          43956    43973      +17     
+ Misses          290      281       -9     
+ Partials        546      538       -8
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 565 <0> (ø) ⬇️
...nal/operators/flowable/FlowableElementAtMaybe.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...al/operators/flowable/FlowableElementAtSingle.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.92%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.25% <0%> (-1.15%) 2% <0%> (ø)
...io/reactivex/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 97.5% <0%> (-0.84%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-0.54%) 5% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a644739...7f120bf. Read the comment docs.

@akarnokd
Copy link
Member

Could you hold up your subsequent PRs until the refactor of the packages?

@akarnokd akarnokd merged commit f8841c7 into ReactiveX:3.x Aug 16, 2019
@akarnokd akarnokd added the 3.x label Aug 16, 2019
@akarnokd akarnokd added this to the 3.0 milestone Aug 16, 2019
@davidmoten
Copy link
Collaborator Author

Could you hold up your subsequent PRs until the refactor of the packages?

Sure.

@davidmoten davidmoten changed the title elementAt, first - constrain upstream requests 3.x: elementAt, first - constrain upstream requests Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants